Skip to content

Clear identification of ShellSession internal API - #9804

Open
jtulach wants to merge 2 commits into
apache:masterfrom
jtulach:jtulach/JShellSessionImpl
Open

jtulach wants to merge 2 commits into
apache:masterfrom
jtulach:jtulach/JShellSessionImpl

Conversation

@jtulach

@jtulach jtulach commented Nov 14, 2026

Copy link
Copy Markdown
Contributor
  • this PR proposes a refactoring of the jshell.support module's ShellSession, however ...
  • my primary goal is elsewhere:
    • I have a JShell instance
    • I'd like to connect such an instance to the existing NetBeans JShell editing functionality
    • however that functionality seems to demand to create its own JShell instance
    • I am searching for the smoothest way to untangle the creation from the rest of editing functionality
    • @lahodaj, @sdedic your guidance is welcomed to help me achieve such a goal!
  • previous ShellSession mixed API and implementation
    • cleaning that up was thus my first idea
    • this PR is result of such a cleanup
    • it moves the implementation into ShellSessionImpl
  • the rest of the module is supposed to call only the ShellSession API class
    • only ShellEnvironment instantiates and deals directly with ShellSessionImpl
  • such a refactoring shall be harmless and potentially useful for the goal of attaching existing JShell instance

@jtulach jtulach added this to the NB33 milestone Nov 14, 2026
@jtulach
jtulach requested review from lahodaj and sdedic November 14, 2026 07:09
@jtulach jtulach self-assigned this Nov 14, 2026
@jtulach jtulach added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant