Repository navigation
Conversation
SourcePath filtered the source path to roots whose usages index passed hasSourceCache(root, true), which only sees persistent, INITIALIZED indices. Roots with a transient index (lazily created at project load, not re-indexed in the current session) were silently dropped, so sources-only Find Usages searches missed their usages. Use hasSourceCache(root, false), which also sees transient indices and does not require INITIALIZED, matching what ClassIndex.createQueriesForRoots queries anyway. Adds a regression test in SourcePathTest reproducing the transient index state. Assisted-by: qwen3.8-27b
mbien
added
Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourcePathfiltered the source path to roots whose usages index passedhasSourceCache(root, true), which only sees persistent,INITIALIZEDindices.Roots with a transient index (lazily created at project load, not re-indexed in the current session) were silently dropped, so sources-only Find Usages searches missed their usages.
Use
hasSourceCache(root, false), which also sees transient indices and does not requireINITIALIZED, matching whatClassIndex.createQueriesForRootsqueries anyway.Adds a regression test in
SourcePathTestreproducing the transient index state.fixes #9685
Assisted-by: qwen3.8-27b