Repository navigation
Terminal: Enable display of characters unsupported by chosen terminal font - #9797
Merged
matthiasblaesing merged 2 commits intoNov 12, 2026
Merged
matthiasblaesing merged 2 commits into
matthiasblaesing merged 2 commits into
Conversation
… font It was noticed that characters were sometime drawn as the "missing glyph". This is mostly noticable with modern terminal applications drawing progressbars and other more special glyphs. This is the same approach as taken in b5c194d: It was noticed, that in some contexts Swing was able to display characters unsupported by the currently chosen font. The problem was observed with emojis. Investigation showed, that the problem appears if a font is explicitly constructed via the constructor, but vanishes if the font is accessed via StyleContext#getFont. The difference is that StyleContext#getFont returns a CompositeFont, that fallsback to other fonts for undefined glyphs. As CompositeFont is located in the sun.font package, it can't be accessed directly. Instead the font acccess via the DefaultStyleContext is used.
matthiasblaesing
added
Platform
Member
|
CI seems to be stuck here even before the "waiting for nodes" phase. Will try to cancel and restart it. edit: cancel isn't working either :( |
mbien
approved these changes
Nov 12, 2026
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
changes look good.
I think this will now create a cascading font which falls back to another font on a per-symbol basis if a symbol isn't found, right?
old dev build (around NB 32 lvl):
this PR:
Contributor
Author
|
@mbien thanks for review. Indeed the composite font is created/used. That fix is transferred/adapted from matthiasblaesing@b5c194d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was noticed that characters were sometime drawn as the "missing glyph". This is mostly noticable with modern terminal applications drawing progressbars and other more special glyphs.
Before:
After:
