Repository navigation
PyArrow: Keep the row count when a scan selects no columns - #4161
Open
vibhuthespeedst wants to merge 1 commit into
Open
vibhuthespeedst wants to merge 1 commit into
vibhuthespeedst wants to merge 1 commit into
Conversation
Closes apache#4137 Generated-by: AI assistant
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4137
Rationale for this change
table.scan(selected_fields=()).to_arrow()returned 0 rows instead of the row count with no columns. Two places lost the rows:_to_requested_schemabuilds the struct from zero fields, which has length 0, andArrowScan.to_tableusespa.concat_tables, which drops the rows of tables without columns.Are these changes tested?
Yes, two tests in
tests/io/test_pyarrow.py, with and without a row filter. Both fail without the fix.Are there any user-facing changes?
Scans that select no columns now return the right number of rows.
Generated-by: AI assistant