Repository navigation
Conversation
Author
|
@rambleraptor @Fokko is it possible to get a review here, or have I done anything sidestepping the process? |
amdubovoi
force-pushed
the
fix/gcs-token-expiry
branch
from
October 28, 2026 00:26
db451ef to
1efa819
Compare
amdubovoi
force-pushed
the
fix/gcs-token-expiry
branch
from
October 28, 2026 09:11
1efa819 to
12b4ccb
Compare
Author
|
@kevinjqliu May I ask you to take a look since you've touched gcsfs stuff previously? And sorry for pinging once again, kinda blocked by this 😢 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FsspecFileIOpasses the GCS token to gcsfs without its expiry. gcsfs 2026.2.0 and later then look up the expiry at tokeninfo, which fails for down-scoped tokens that REST catalogs vend. Reads fail withProvided token is either not valid, or expired.A token with
gcs.oauth2.token-expires-atnow goes to gcsfs asgoogle.oauth2.credentials.Credentialswith that expiry.Are these changes tested?
Yes, with unit tests and against a REST catalog that vends down-scoped GCS tokens.
Are there any user-facing changes?
Yes. Vended GCS credentials work again with gcsfs 2026.2.0 and later.