Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The Chinese page matches the English source row for row, and the English edit is whitespace-only. Three leftovers still send readers to English docs or mark the page as untranslated.
| | -------- | --------------- | ---------- | | ||
| | **CD10** | 项目以免费方式向公众发布开源软件。 | **是** 项目源代码采用 `Apache License 2.0` 许可。 | | ||
| | **CD20** | 任何人都可以方便地发现并访问项目代码。 | **是** [官方网站](https://hugegraph.apache.org/)包含指向 [GitHub 仓库](https://github.com/apache/hugegraph)的链接。 | | ||
| | **CD30** | 任何人都可以使用标准且广泛可用的工具以可复现的方式构建代码。 | **是** Apache HugeGraph 提供了[快速上手](https://hugegraph.apache.org/docs/quickstart/hugegraph/hugegraph-server/)文档,说明如何编译源代码。 | |
There was a problem hiding this comment.
Minor: This page links to the English docs on lines 27, 29, 45, 57, 66 and 69, though each target has a Chinese page under /cn/docs/. Point these links at the /cn/docs/... paths, as other content/cn pages do.
| @@ -0,0 +1,88 @@ | |||
| --- | |||
| title: 成熟度 | |||
There was a problem hiding this comment.
Minor: data/landing/community/cn.yaml still calls this assessment 英文版, while its /community/maturity/ link renders as /cn/community/maturity/ once this page exists. Drop 英文版 from that sentence.
| weight: 50 | ||
| --- | ||
|
|
||
| # Apache HugeGraph 成熟度评估 |
There was a problem hiding this comment.
Minor: HREFLANG_FALLBACKS in dist/validate-site-output.py and scripts/versioning.py still maps community/maturity/index.html to /cn/, so a full dist/validate-site-output.py run reports an hreflang mismatch for this page. Remove both entries.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: content/cn/community/maturity.md matches the English page row for row, and the English edit only replaces padding with plain spaces. The Chinese doc links, the 英文版 label and the HREFLANG_FALLBACKS entries from the earlier review are fixed at this head.
imbajin
left a comment
There was a problem hiding this comment.
Score: 8.0/10 · Confidence: medium
Blocking: no
Summary
The Chinese community entry still opens the English assessment.
Evidence
The unchanged absolute link renders to the English URL on the live site; the PR changes the label but retains that link. The landing Markdown rendering path does not localize the URL.
Validation notes
The PR-head local build could not run with the installed older Hugo; historical multi-version assembly was inspected statically.
| data: | ||
| title: 了解项目运作方式 | ||
| body: Apache HugeGraph 使用英文版 [项目成熟度评估](/community/maturity/) 记录社区实践。 | ||
| body: Apache HugeGraph 使用 [项目成熟度评估](/community/maturity/) 记录社区实践。 |
There was a problem hiding this comment.
This Markdown link still points to /community/maturity/. The landing Markdown renderer preserves that URL, so visitors following it from the Chinese community page reach the English assessment even though the new Chinese page is available. Please change the target to /cn/community/maturity/.
Purpose of the PR
No issue; the Chinese site is missing a page the English site has.
What changed
content/cn/community/maturity.md, a Chinese translation of the Apache maturity assessment that already lives atcontent/en/community/maturity.md(moved there in feat: generate maturity to frontend #440). Same structure, same table IDs, same links, with internal links pointing to/cn/docs/...and/cn/community/....HREFLANG_FALLBACKSinscripts/versioning.pyanddist/validate-site-output.pyso multi-version builds where older branches only carry the English maturity assessment resolve the fallback cleanly.How verified
hugo 0.168.0extended (pinned inhugo.yaml) withgo 1.27.3passes strict build (--panicOnWarning --printPathWarnings --gc --minify); both/community/maturity/and/cn/community/maturity/render.scripts/validate-links.shandpytest(290 passed, 1 skipped) pass.grepconfirms noU+00A0remains in either page.