Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The standalone deployment, Gremlin binding and shard-scan text matches apache/hugegraph master 8e327b8 or is scoped to the fixes in apache/hugegraph#3447, but the Topling default-profile paragraph describes a profile that no build ships until apache/hugegraph#3447 merges.
- Distinguish standalone RocksDB artifacts from HStore and Helm single-node presets. - Document required scan bounds and explicit pagination without changing the unpaged contract. - Correct standalone Gremlin aliases and GraphSpace-scoped traversal sources. - Clarify ToplingDB community SkipList/BlockBasedTable profile version boundary (Server 1.8.0+ / #3447 vs legacy cspp memtable).
ca75f7e to
9348fc4
Compare
|
Thanks @bitflicker64 for the careful review! This PR has been rebased onto current
|
Limit empty shard bounds to supported backends and describe the all-backend required-bound change. Qualify local-backend image reuse by the wait and data-directory fixes. Document Topling configuration precedence, absolute path handling and legacy CSPP upgrade requirements.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The standalone deployment, Gremlin binding, shard-scan and HStore-reuse text matches apache/hugegraph master 8e327b8 and 1.7.0, or is scoped to fixes in open apache/hugegraph#3447. The Topling version note added since the last review misstates what master and 1.7.0 ship.
|
Review follow-up at Validation on this revision: |
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The standalone deployment, Gremlin binding and shard-scan text matches apache/hugegraph master 0abd931 and 1.7.0, and the Topling profile, preparation and scan-validation behaviour is scoped to builds containing apache/hugegraph#3447, which resolves both earlier Topling findings.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The standalone deployment, Gremlin binding and shard-scan text matches apache/hugegraph master 8828d82 and 1.7.0, and the Topling profile, preparation and scan-validation behaviour stays scoped to builds containing apache/hugegraph#3447 (head a6d72a5). The changes since the last approval scope the edge-scan rule to that fix, replace the relative-path normalization claim with an absolute-path requirement, and split paragraphs.
Before → After
Before: Standalone setup contracts, shard-bound requirements, and community-native Topling profile preparation were not documented consistently across both languages.
After:
origin/master(post-docs: unify client navi struct and streamline GQL docs (EN/CN) #557), cleanly incorporating PR docs: unify client navi struct and streamline GQL docs (EN/CN) #557's OINK components (Steps, Tabs, Cards, Alerts) and traverser batch APIs alongside PR docs: clarify standalone deployment contracts #559's standalone deployment contracts.rocksdb-data), configuration write permissions, and Java 17/auth initialization.__g_DEFAULT-hugegraphand graph bindingDEFAULT-hugegraph.startandendbounds (explicit empty values for open bounds, HTTP 400 when missing) and explicitpagepagination semantics for vertex and edge scans.apache/hugegraph#3447. Earlier development builds may require CSPP plugins; Server 1.7.0 does not include that profile orprepare-topling.sh. The documentation and implementation should be merged in that order.Source: hugegraph#60
Paired implementation source: apache/hugegraph#3447
Validation boundary & results
./scripts/hugo.sh buildrenders all 668 pages (EN: 335, CN: 333) with 0 errors.bash dist/validate-links.shpasses with 0 broken links.python3 -m unittest discover -s scripts/passes all 290 tests (1 skipped).git diff --checkclean.Visual overview
Before → After: missing shard bounds return HTTP 400 while explicit empty bounds remain valid; Topling preparation adds actual-profile native import after the isolated EasyMigrate probe, before installing local runtime files. Profile import does not open production databases or convert existing SSTs, and it does not establish deployment or data-compatibility acceptance.