Repository navigation
fix(vermeer): make Louvain output readiness explicit - #372
Merged
imbajin merged 2 commits intoNov 5, 2026
Merged
Conversation
This was referenced Nov 5, 2026
MrJs133
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Louvain output eligibility is inferred from first-pass state. Add a separate atomic publication flag to both Louvain implementations, clear it before rebuilding community IDs, and publish readiness after construction. Reject output while the result is unpublished.
Validation boundary
This is defensive hardening, not a reproduced production race. The existing master/worker step barrier already prevents output during BeforeStep; the new unit test constructs unpublished state directly. The author reports Go 1.23.7 race tests for algorithms and worker packages; these were not independently rerun for this submission. Publication-path coverage and cluster acceptance remain separate.
Source: 🔗 org Computer #25.
Visual overview
Defensive readiness illustration: publish complete community IDs before allowing output. This does not establish that the originally claimed concurrent-output race occurs in production, or that publication-path, multi-worker or deployment acceptance has passed.