Repository navigation
Conversation
arturobernalg
requested changes
Oct 31, 2026
arturobernalg
left a comment
Member
There was a problem hiding this comment.
The default hostname verifier fallback was intentionally removed in #649.
Would it be better to fix the Conscrypt constructor to use BUILTIN by default, and reject CLIENT without a verifier, rather than restoring the fallback in AbstractClientTlsStrategy?
I'd prefer to preserve the existing separation between verification policy and verifier configuration.
Member
|
@Hsnmohd I agree with @arturobernalg Let's fix it in Conscrypt classes instead. |
Member
|
@Hsnmohd This is wrong and must be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractClientTlsStrategylost its null-verifier fallback in #649, sonew ConscryptClientTlsStrategy(sslContext)(which hardcodesCLIENT) andsetHostVerificationPolicy(CLIENT)without a verifier skip both endpoint identification and the post-handshake check, and a real exchange withhttps://some-other-hostagainst aCN=localhostcertificate returns 200 through classic, async and a Conscrypt engine, so restoreHttpsSupport.getDefaultHostnameVerifier()forCLIENTandBOTH.