Skip to content

Use PrefixedIncrementingId for BasicHttpClientConnectionManager id #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 1 commit into from
Oct 30, 2026
Merged

Use PrefixedIncrementingId for BasicHttpClientConnectionManager id #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...t5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicReference;
import java.util.concurrent.locks.ReentrantLock;

Expand All @@ -46,6 +45,7 @@
import org.apache.hc.client5.http.impl.ConnPoolSupport;
import org.apache.hc.client5.http.impl.ConnectionHolder;
import org.apache.hc.client5.http.impl.ConnectionShutdownException;
import org.apache.hc.client5.http.impl.PrefixedIncrementingId;
import org.apache.hc.client5.http.io.ConnectionEndpoint;
import org.apache.hc.client5.http.io.HttpClientConnectionManager;
import org.apache.hc.client5.http.io.HttpClientConnectionOperator;
Expand Down Expand Up @@ -100,7 +100,7 @@ public class BasicHttpClientConnectionManager implements HttpClientConnectionMan

private static final Logger LOG = LoggerFactory.getLogger(BasicHttpClientConnectionManager.class);

private static final AtomicLong COUNT = new AtomicLong(0);
private static final PrefixedIncrementingId INCREMENTING_ID = new PrefixedIncrementingId("ep-");

private final HttpClientConnectionOperator connectionOperator;
private final HttpConnectionFactory<ManagedHttpClientConnection> connFactory;
Expand Down Expand Up @@ -130,7 +130,7 @@ public BasicHttpClientConnectionManager(
super();
this.connectionOperator = Args.notNull(httpClientConnectionOperator, "Connection operator");
this.connFactory = connFactory != null ? connFactory : ManagedHttpClientConnectionFactory.INSTANCE;
this.id = String.format("ep-%010d", COUNT.getAndIncrement());
this.id = INCREMENTING_ID.getNextId();
this.expiry = Long.MAX_VALUE;
this.socketConfig = SocketConfig.DEFAULT;
this.connectionConfig = ConnectionConfig.DEFAULT;
Expand Down
Loading