Repository navigation
TestLinearBackoffManager: Re-enable probeUpdatesRemainingAttemptsIndirectly - #909
Merged
Merged
Conversation
…rectly The test lost its @test annotation in apache#494, when the Thread.sleep() calls were replaced, and has not run since. As rewritten it also could not pass: the second probe was still inside the cool-down period started by the preceding backOff, so the pool size stayed at 6. Age the last backoff together with the last probe before the second probe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probeUpdatesRemainingAttemptsIndirectly lost its @test in #494 and has not run since. #494 replaced Thread.sleep() with ageing lastRouteProbes, but the sleep also aged the last backoff, so the second probe is now skipped and the test fails (expected 5, was 6). This restores @test and ages lastRouteBackoffs as well.