Repository navigation
TlsRequiredAsyncExec must not proceed down the exec chain after failing the exchange for a cleartext route - #905
Merged
arturobernalg merged 1 commit intoOct 29, 2026
Conversation
…ng the exchange for a cleartext route
arturobernalg
force-pushed
the
tls-required-async-exec
branch
from
October 28, 2026 08:25
d62d45b to
47f52b4
Compare
ok2c
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TlsRequiredAsyncExecfails the exchange for a cleartext route and then callschain.proceedanyway. The caller gets the failure, but the request is still handed to the rest of the chain. The classicTlsRequiredExecthrows and is not affected.Adds a unit test for the exec and two integration tests that verify a rejected request never reaches the exec elements past the TLS check, with a cold pool and with a connection manager shared with a plain client. Both fail without the fix.