Repository navigation
Fineract 3128: Move loan COB services, listeners and API out of fineract-provider - #6933
Open
shubhamchaudhary29 wants to merge 2 commits into
Open
shubhamchaudhary29 wants to merge 2 commits into
shubhamchaudhary29 wants to merge 2 commits into
Conversation
The loan COB package (cob/loan) lived in fineract-provider. It now lives in fineract-loan, next to the existing LoanCOBBusinessStep, the way the working capital loan COB already lives in fineract-working-capital-loan. The writers checked the progressive loan model through ProgressiveLoanModelProcessingService, which is in fineract-progressive-loan, and that module depends on fineract-loan. They now use a new ProgressiveLoanModelService interface in fineract-loan, which that service implements. Its hasValidModel(Long) uses the current model version, so the writers behave as before. LoanCOBEnabledCondition, LoanAccountLock, the two stayed-locked data classes and the chunk and inline COB loan item listeners move too, since the moved code needs them and they only depend on fineract-core and fineract-cob. WorkingCapitalInlineCOBLoanItemReader and WorkingCapitalLoanInlineCOBConfig go to fineract-working-capital-loan instead, because they use working capital loan classes. Packages are unchanged. The unit tests move with their classes, except the Cucumber step definitions, whose features and runner are in fineract-provider, and CobNoRetryTest and CobSequentialProcessingTest, which also wire the working capital loan COB.
The cob api, service, listener, data and domain classes lived in fineract-provider. The generic catch-up and inline COB parts now live in fineract-cob, the loan parts in fineract-loan and the working capital loan parts in fineract-working-capital-loan, which depends on fineract- loan. Only cob.savings.RetrieveSavingsIdServiceImpl stays, because it is not loan COB. The catch-up services started jobs through JobStarter and ScheduledJobDetailRepository, and read the running catch-up business date through JobExecutionRepository, all in fineract-provider. They now use two new fineract-core interfaces: ScheduledJobStartService, implemented in fineract-provider by ScheduledJobStartServiceImpl, and RunningJobBusinessDateService, which JobExecutionRepository implements. ScheduledJobStartServiceImpl looks up the scheduled job on each catch-up day instead of once per catch-up, which adds one SELECT per day. JobNotFoundException, InlineExecutorService, NextJobParametersResolver, SchedulerServiceConstants and TaskExecutorConstant move to fineract- core, since the moved code needs them and they only depend on fineract- core and Spring. Packages are unchanged. InlineLoanCOBExecutorServiceImplTest moves to fineract-loan. CatchUpAfterJobListenerTest stays in fineract-provider, because it wires both the loan and the working capital loan catch-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FINERACT-3128
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.