Repository navigation
FINERACT-2968: Update dependency io.cucumber:cucumber-bom to v8 - #6862
renovate-bot wants to merge 1 commit into
Conversation
galovics
left a comment
There was a problem hiding this comment.
This doesn't compile, build-core fails on :fineract-e2e-tests-runner:compileTestJava with Could not find io.qameta.allure:allure-cucumber7-jvm:. - the allure plugin leaves the cucumber7 adapter without a version once the cucumber 8 artifacts show up on the classpath. So bumping the BOM alone isn't enough. On top of that the dependencySet(group: 'io.cucumber', version: '7.34.3') pin is still there, so even if it resolved we'd end up with cucumber-java/-spring/-junit-platform-engine on 7.34.3 and cucumber-core/datatable/gherkin/cucumber-junit on 8.0.4. That mixed classpath is not something I'd want to merge.
The upgrade needs a manual PR: drop or bump the 7.34.3 pin, switch the adapter to allure-cucumber8-jvm together with the plugin = [...] class in fineract-e2e-tests-runner/build.gradle, then let the cucumber and e2e jobs run. Until then this one can't go in.
buildSrc/src/main/groovy/org.apache.fineract.dependencies.gradle:42
- mavenBom 'io.cucumber:cucumber-bom:7.34.3'
+ mavenBom 'io.cucumber:cucumber-bom:8.0.4'The
dependencySet(group: 'io.cucumber', version: '7.34.3')further down still pins cucumber-java, cucumber-java8, cucumber-junit-platform-engine and cucumber-spring to 7.x, so we'd get half 7, half 8. Those have to move together with the BOM, or the pin goes and the BOM drives them.
This PR contains the following updates:
7.34.3→8.0.4Release Notes
cucumber/cucumber-jvm (io.cucumber:cucumber-bom)
v8.0.4Compare Source
Fixed
v8.0.3Compare Source
Changed
Fixed
v8.0.2Compare Source
Fixed
Method::canAccessis not available on Android (#3249)v8.0.1Compare Source
Fixed
v8.0.0Compare Source
Added
@Before,@After,@BeforeStepand@AfterStephooks and emit hook names in messages (#2917, #3173)ParallelHierarchicalTestExecutorServiceFactory(#3105)cucumber.execution.threadsproperty when executing from CLI (#3183)cucumber.glue.classesproperty or the--glue-classesCLI option (#3120).{included,excluded}-class-name-patternproperty and the--glue-{included,excluded}-class-name-patternCLI option. (#3120).@BeforeAlland@AfterAllhooks (#3236)Changed
Deprecated
cucumber-testngfor removal in favor ofcucumber-junit-platform-engine(#3245)cucumber-junitfor removal in favor ofcucumber-junit-platform-engineFixed
cucumber.filter.nameand align the behavior with JUnit 4 and CLI (#3174)Plugin(#3236)Removed
cucumber-openejbin favor ofcucumber-jakarta-openejb(#3189)cucumber-cdi2in favor ofcucumber-jakarta-cdi(#3192)cucumber-deltaspikewithout replacement (#3193)v7.34.9Fixed
v7.34.8Fixed
AbstractTestNGCucumberTests.scenarios()throws without setup (#3235)v7.34.7Fixed
v7.34.6Fixed
v7.34.5Fixed
v7.34.4Fixed
Configuration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.