Skip to content

Tests: Share quoted-identifier assertions - #2722

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
share-quoted-identifier-tests
Oct 26, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
share-quoted-identifier-tests

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

Quoted-identifier projection assertions share a common test, including Generic coverage. Dialect-specific statement cases stay in their existing suites.

Addresses the quoted-identifier test duplication tracked in #2698.

Mode echoes findings.

@github-actions

Copy link
Copy Markdown

No dialect label was applied because the title does not name a SQL dialect.

If this change targets one or more dialects, edit the title to <Dialect>[, <Dialect>]: <description>, add a Dialects: <Dialect>[, <Dialect>] line to the description, or reply with one. Reply Dialects: none if the change is dialect-agnostic.

Changed files touch ClickHouse, Hive, PostgreSQL, Redshift, Snowflake, SQL Server.

@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.30%. Comparing base (27259c1) to head (1cb4d1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2722   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files          42       42           
  Lines       35294    35294           
  Branches    35294    35294           
=======================================
  Hits        29047    29047           
  Misses       2690     2690           
  Partials     3557     3557           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the share-quoted-identifier-tests branch 2 times, most recently from 412ccdf to c746f90 Compare October 26, 2026 20:18
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

cc @alamb merging the last echo

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 26, 2026
@LucaCappelletti94
LucaCappelletti94 force-pushed the share-quoted-identifier-tests branch from c746f90 to 1cb4d1f Compare October 26, 2026 21:03
@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 23e9e88 Oct 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants