Skip to content

Code style cleanups split out of #12500 - #14556

Open
DaanHoogland wants to merge 1 commit into
removeOvmLeftoversfrom
deprecatedHypervisorCleanups
Open

Code style cleanups split out of #12500#14556
DaanHoogland wants to merge 1 commit into
removeOvmLeftoversfrom
deprecatedHypervisorCleanups

code style cleanups in ApiResponseHelper, Upgrade410to420, AffinityGr…

9fc6df3
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 2, 2026 in 5m 56s

Quality Gate failed

Failed conditions
1.4% Coverage on New Code (required ≥ 40%)
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 933 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O0&open=AaGcm-OImtHvmxH3m8O0&pullRequest=14556

Check warning on line 281 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8MN&open=AaGcm-OImtHvmxH3m8MN&pullRequest=14556

Check warning on line 2466 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NJ&open=AaGcm-OImtHvmxH3m8NJ&pullRequest=14556

Check warning on line 2276 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8PJ&open=AaGcm-OImtHvmxH3m8PJ&pullRequest=14556

Check warning on line 878 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8MZ&open=AaGcm-OImtHvmxH3m8MZ&pullRequest=14556

Check warning on line 320 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NX&open=AaGcm-OImtHvmxH3m8NX&pullRequest=14556

Check failure on line 2514 in server/src/main/java/com/cloud/api/ApiResponseHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 11 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-fcmtHvmxH3m8PN&open=AaGcm-fcmtHvmxH3m8PN&pullRequest=14556

Check warning on line 1842 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8M0&open=AaGcm-OImtHvmxH3m8M0&pullRequest=14556

Check warning on line 927 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Ma&open=AaGcm-OImtHvmxH3m8Ma&pullRequest=14556

Check warning on line 933 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8No&open=AaGcm-OImtHvmxH3m8No&pullRequest=14556

Check warning on line 2028 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8M6&open=AaGcm-OImtHvmxH3m8M6&pullRequest=14556

Check warning on line 2431 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NF&open=AaGcm-OImtHvmxH3m8NF&pullRequest=14556

Check warning on line 1564 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8N-&open=AaGcm-OImtHvmxH3m8N-&pullRequest=14556

Check warning on line 933 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Mb&open=AaGcm-OImtHvmxH3m8Mb&pullRequest=14556

Check warning on line 2373 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OZ&open=AaGcm-OImtHvmxH3m8OZ&pullRequest=14556

Check warning on line 1666 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8My&open=AaGcm-OImtHvmxH3m8My&pullRequest=14556

Check warning on line 2268 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OT&open=AaGcm-OImtHvmxH3m8OT&pullRequest=14556

Check warning on line 927 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Oz&open=AaGcm-OImtHvmxH3m8Oz&pullRequest=14556

Check warning on line 610 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Ng&open=AaGcm-OImtHvmxH3m8Ng&pullRequest=14556

Check warning on line 1941 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8M3&open=AaGcm-OImtHvmxH3m8M3&pullRequest=14556

Check warning on line 2266 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OS&open=AaGcm-OImtHvmxH3m8OS&pullRequest=14556

Check warning on line 1562 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O-&open=AaGcm-OImtHvmxH3m8O-&pullRequest=14556

Check warning on line 2266 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8PH&open=AaGcm-OImtHvmxH3m8PH&pullRequest=14556

Check warning on line 2451 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Oc&open=AaGcm-OImtHvmxH3m8Oc&pullRequest=14556

Check warning on line 1562 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Mo&open=AaGcm-OImtHvmxH3m8Mo&pullRequest=14556
View more details on SonarQubeCloud