Skip to content

disable deprecated plugins - #12500

Open
DaanHoogland wants to merge 4 commits into
4.22from
disableDeprecatedPlugins
Open

DaanHoogland wants to merge 4 commits into
4.22from
disableDeprecatedPlugins

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jan 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.39%. Comparing base (56306ab) to head (f9e625a).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12500      +/-   ##
============================================
+ Coverage     18.30%   18.39%   +0.08%     
- Complexity    16629    16634       +5     
============================================
  Files          5939     5913      -26     
  Lines        537751   535311    -2440     
  Branches      65924    65581     -343     
============================================
+ Hits          98460    98494      +34     
+ Misses       428085   425611    -2474     
  Partials      11206    11206              
Flag Coverage Δ
uitests 4.08% <ø> (ø)
unittests 19.50% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the deprecated UCS and Hyper-V hypervisor plugins by removing them from the build configuration and cleaning up related constants and configurations.

Changes:

  • Removed UCS and Hyper-V hypervisor plugin modules from the plugins build configuration
  • Removed UCS and Hyper-V plugin dependencies from the client module
  • Removed UCS-related configuration setting (UCSSyncBladeInterval) from server configuration
  • Removed two UCS-related API constants (UCS_DN and UCS_MANAGER_ID)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
plugins/pom.xml Removed hyperv and ucs hypervisor modules from the build
client/pom.xml Removed cloud-plugin-hypervisor-ucs and cloud-plugin-hypervisor-hyperv dependencies
server/src/main/java/com/cloud/configuration/Config.java Removed UCSSyncBladeInterval configuration enum entry
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java Removed UCS_DN and UCS_MANAGER_ID constants

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@apache apache deleted a comment from blueorangutan Jan 22, 2026
@apache apache deleted a comment from blueorangutan Jan 22, 2026
@apache apache deleted a comment from blueorangutan Jan 22, 2026
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16502

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
62.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
DaanHoogland force-pushed the disableDeprecatedPlugins branch from 1d3bad0 to 0e42c76 Compare January 29, 2026 16:09
@weizhouapache weizhouapache added this to the 4.24.0 milestone Jun 29, 2026
@DaanHoogland DaanHoogland moved this from Backlog to conflict/waiting for author in CloudStack Testing Aug 31, 2026
@nvazquez

Copy link
Copy Markdown
Contributor

Hi @DaanHoogland can you please address the conflicts?

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: conflict/waiting

Development

Successfully merging this pull request may close these issues.

6 participants