Repository navigation
Fix collections.abc pretty type - #40923
Merged
Merged
Conversation
github-actions
Bot
added
Next Action: Reviewers
python
size/xs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR updates pretty_type in sdks/python/gen_xlang_wrappers.py to handle generic aliases from collections.abc (such as collections.abc.Sequence and collections.abc.Mapping) in addition to typing. The change is clean, minimal, and restores the expected type formatting for external transform wrapper generation.
🔍 General Feedback
- Consider adding test cases for
collections.abc.Sequenceandcollections.abc.MappingtoAutoGenerationScriptIT.test_pretty_typesinsdks/python/apache_beam/transforms/external_transform_provider_it_test.pyto prevent future regressions.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
aIbrahiim
approved these changes
Oct 31, 2026
Amar3tto
added a commit
that referenced
this pull request
Oct 31, 2026
Cherrypick #40923 Fix collections.abc pretty type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.