Repository navigation
refactor: replace ValueCell and standardize first-party API docs - #424
Merged
tisonkun merged 4 commits intoNov 13, 2026
Merged
Conversation
Replace the Cargo/Tokio-style '# Cancel safety' heading with '# Cancellation' across AGENTS.md and crate docs, rewrite remaining verbatim or closely adapted upstream comments and examples in singleflight, once_map, once, barrier, broadcast, mutex, semaphore, and oneshot, fix misleading/second-person phrasing and US spelling inconsistencies, and drop unqualified cancellation-safety claims.
tisonkun
enabled auto-merge (squash)
November 13, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several primitives retained verbatim or lightly adapted third-party documentation, examples, comments, and tests alongside Asyncband's own contracts, and
internal::ValueCellstill carried a Tokio-derivedSetOncewrapper.asyncband/src/internal/value_cell.rswith a first-partyValueCell<T>built onAtomicBoolpublication andUnsafeCell<MaybeUninit<T>>, updateLazyCellandOnceCellcall sites, and removevalue_cell.rsfrom third-partyLICENSEnotices.LICENSEthat the standard ASF header onasyncband/src/once/once_cell/mod.rscovers Asyncband's modifications while retained Tokio-derived portions remain under the MIT License, matching the existingMutex,RwLock, andSemaphoreentries.Returns,Errors,Cancellation,Panics,Deadlocks, andExamples) across all primitives and codify these documentation guidelines inAGENTS.md.