Repository navigation
Conversation
…dataset The segment_encoding option was already respected when reading a directory-partitioned dataset, but ignored when writing. This change now URI encodes path segments if the encoding mode is set to Uri. In addition, invalid path segments now raise an error if they are invalid.
This comment was marked as low quality.
This comment was marked as low quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Make dataset writing with directory and filename partitioning able to use URI encoding, to support writing values that require encoding to round-trip correctly.
What changes are included in this PR?
When writing a dataset with
DirectoryPartitioningorFilenamePartitioning, respect thesegment_encodingparameter and use URI encoding if it is enabled. Note that it's enabled by default, so this changes the default behaviour. Previously thesegment_encodingparameter was only used when reading.This also adds additional validation when no encoding is used, and rejects empty string values that cannot be round-tripped correctly with these two partitioning methods.
Are these changes tested?
Yes, this includes new unit tests.
Are there any user-facing changes?
Yes.
DirectoryPartitioningandFilenamePartitioningboth now URI encode path segments by default. This can be disabled if desired to revert to the previous behaviour by setting the thesegment_encodingparameter to "none".Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: