Repository navigation
Conversation
…endency not found
|
|
raulcd
marked this pull request as ready for review
November 5, 2026 12:21
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change preserving Arrow’s CMake module search path during ORC discovery.
No open issues 🎉
What changed in this PR
Preserves Arrow’s CMake module search path when ORC dependency discovery fails, preventing later lookups such as AWS SDK discovery from losing access to Arrow’s find modules.
Changes:
- Saves and restores
CMAKE_MODULE_PATHaroundfind_package(orc), then removes the temporary variable. - Documents why ORC’s early return requires this workaround.
| File | Description |
|---|---|
cpp/cmake_modules/FindorcAlt.cmake |
Preserves the module search path across ORC discovery. |
Review effort: Balanced
Contributor
|
Thanks a lot for debugging this. I think this is good as an intermediate fix; better would be for orc to fix this for itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When a dependency is not found on ORC its
find_dependencyreturns without resetting previousCMAKE_MODULE_PATH:https://github.com/apache/orc/blob/32046606774da481182dce2956f336dc8e79a579/c%2B%2B/orcConfig.cmake.in#L45-L55
What changes are included in this PR?
Maintain our
CMAKE_MODULE_PATHbefore calling ORC.Are these changes tested?
Not on our CI but this has been tested on downstream arrow-cpp-feedstock here:
conda-forge/arrow-cpp-feedstock#2100
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: