Skip to content

EXP: Emscripten toolchain upgrade - #55414

Closed
tadeja wants to merge 7 commits into
apache:mainfrom
tadeja:emscripten-toolchain-upgrade
Closed

tadeja wants to merge 7 commits into
apache:mainfrom
tadeja:emscripten-toolchain-upgrade

Conversation

@tadeja

@tadeja tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Experiment for PR #55381 - update emscripten_version="3.1.45" to "4.0.14"

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@tadeja

tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit *-emscripten

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Revision: 22ed7f1

Submitted crossbow builds: ursacomputing/crossbow @ actions-a280fa770b

Task Status
test-conda-python-emscripten GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions

@tadeja

tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

test-conda-python-emscripten job passed but it doesn't use bumped emscripten_version 4.0.14 -->
Python job uses 3.1.58
https://github.com/ursacomputing/crossbow/actions/runs/42012743959/job/127195591727#step:7:456

  #13 [ 7/11] RUN bash /arrow/ci/scripts/install_emscripten.sh ~ /pyodide
  #13 2.806 Cloning into 'emsdk'...
  #13 3.927 Resolving SDK version '3.1.58' to 'sdk-releases-a4d4afb626c5010f6ccda4638b8d77579a63782e-64bit'

@raulcd

raulcd commented Nov 5, 2026

Copy link
Copy Markdown
Member

This seems to be tied to the pyodide version used:

ARG pyodide_version="0.27.1"

Maybe we should see what emscripten version pyodide latest uses:
https://github.com/pyodide/pyodide/releases/tag/0.27.8

@tadeja

tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

test-ubuntu-22.04-cpp-emscripten job uses bumped Emscripten version 4.0.14 and now fails 93 of 96 tests during WebAssembly validation, before tests even run.
https://github.com/ursacomputing/crossbow/actions/runs/42012743689/job/127195591057#step:7:4965

Test project /build/cpp
      Start  1: arrow-array-test
 1/96 Test  #1: arrow-array-test ..........................***Failed    0.29 sec
failed to asynchronously prepare wasm: CompileError: WebAssembly.instantiate(): Compiling function #24034:"simdjson::internal::parse_decimal(char const*&)" failed: expected 0 elements on the stack for fallthru, found 1 @+26282779

Aborted(CompileError: WebAssembly.instantiate(): Compiling function #24034:"simdjson::internal::parse_decimal(char const*&)" failed: expected 0 elements on the stack for fallthru, found 1 @+26282779)
/build/cpp/debug/arrow-array-test.js:367
  var e = new WebAssembly.RuntimeError(what);
          ^

Node.js v24.19.0
...

3% tests passed, 93 tests failed out of 96

@tadeja

tadeja commented Nov 5, 2026 •

Copy link
Copy Markdown
Member Author

This seems to be tied to the pyodide version used:

ARG pyodide_version="0.27.1"

Maybe we should see what emscripten version pyodide latest uses: https://github.com/pyodide/pyodide/releases/tag/0.27.8

Ha, ok!
I've checked this major Pyodide update PR #47330 and it is planning to update also conda-python-emscripten.dockerfile
https://github.com/apache/arrow/pull/47330/changes#diff-7a0e490808321f7e1e1a6ca5cf1e93c7a410de4b47bad506aca3a75334d67922R25

- ARG pyodide_version="0.27.1"
+ ARG pyodide_version="314.0.7"

@tadeja

tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Revision: cd20788

Submitted crossbow builds: ursacomputing/crossbow @ actions-30a0e5d7c4

Task Status
test-ubuntu-22.04-cpp-emscripten GitHub Actions

@tadeja

tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-python-emscripten

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Revision: cd20788

Submitted crossbow builds: ursacomputing/crossbow @ actions-a0357733b4

Task Status
test-conda-python-emscripten GitHub Actions

@tadeja

tadeja commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Test completed, closing. See PR #55417

@tadeja tadeja closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants