Repository navigation
GH-55406: [C++][Parquet] Test AES-CTR plaintext footer example file - #55407
Merged
Merged
Conversation
Also allow generating parquet-testing files by setting a PARQUET_ENCRYPTION_TEST_OUTPUT_DIR environment variable.
adamreeve
marked this pull request as ready for review
November 5, 2026 00:04
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the added Parquet encryption test coverage and fixture-generation support.
No open issues 🎉
What changed in this PR
Expands Parquet encryption test coverage for AES-CTR files with plaintext footers, addressing GH-55406, and adds support for regenerating encrypted test fixtures.
Changes:
- Adds write and read coverage for the plaintext-footer AES-CTR configuration, including reads without decryption keys.
- Adds optional fixture export through
PARQUET_ENCRYPTION_TEST_OUTPUT_DIR, using settings that matchparquet-testingfiles.
| File | Description |
|---|---|
cpp/src/parquet/encryption/write_configurations_test.cc |
Adds the encryption configuration and optional fixture export with a Snappy requirement. |
cpp/src/parquet/encryption/test_encryption_util.h |
Declares fixture-generation settings and the factory method. |
cpp/src/parquet/encryption/test_encryption_util.cc |
Implements the fixture layout and applies compression, version, and encoding settings. |
cpp/src/parquet/encryption/read_configurations_test.cc |
Adds the AES-CTR plaintext-footer fixture to decryption and legacy-read coverage. |
Review effort: Balanced
wgtmac
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
More test coverage.
What changes are included in this PR?
parquet-testingsubmodule.PARQUET_ENCRYPTION_TEST_OUTPUT_DIRenvironment variable when running the tests. This could be useful if we need to generate similar test files in the future.Are these changes tested?
Yes
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: