Skip to content

GH-55406: [C++][Parquet] Test AES-CTR plaintext footer example file - #55407

Merged
adamreeve merged 3 commits into
apache:mainfrom
adamreeve:test-aes-ctr-plaintext-footer
Nov 5, 2026
Merged

adamreeve merged 3 commits into
apache:mainfrom
adamreeve:test-aes-ctr-plaintext-footer

Conversation

@adamreeve

@adamreeve adamreeve commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Rationale for this change

More test coverage.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI (code only, not description)

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Also allow generating parquet-testing files by setting a
PARQUET_ENCRYPTION_TEST_OUTPUT_DIR environment variable.
@adamreeve
adamreeve marked this pull request as ready for review November 5, 2026 00:04
Copilot AI balanced review requested due to automatic review settings November 5, 2026 00:04
@github-actions github-actions Bot added the awaiting review Awaiting review label Nov 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the added Parquet encryption test coverage and fixture-generation support.

No open issues 🎉

What changed in this PR

Expands Parquet encryption test coverage for AES-CTR files with plaintext footers, addressing GH-55406, and adds support for regenerating encrypted test fixtures.

Changes:

  • Adds write and read coverage for the plaintext-footer AES-CTR configuration, including reads without decryption keys.
  • Adds optional fixture export through PARQUET_ENCRYPTION_TEST_OUTPUT_DIR, using settings that match parquet-testing files.
File Description
cpp/​src/​parquet/​encryption/​write_configurations_test.cc Adds the encryption configuration and optional fixture export with a Snappy requirement.
cpp/​src/​parquet/​encryption/​test_encryption_util.h Declares fixture-generation settings and the factory method.
cpp/​src/​parquet/​encryption/​test_encryption_util.cc Implements the fixture layout and applies compression, version, and encoding settings.
cpp/​src/​parquet/​encryption/​read_configurations_test.cc Adds the AES-CTR plaintext-footer fixture to decryption and legacy-read coverage.

Review effort: Balanced

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 5, 2026
Copilot AI balanced review requested due to automatic review settings November 5, 2026 08:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the AES-CTR plaintext-footer coverage and fixture-export changes.

No open issues 🎉

Review effort: Balanced

@adamreeve
adamreeve merged commit 7f1f38d into apache:main Nov 5, 2026
57 of 58 checks passed
@adamreeve adamreeve removed the awaiting committer review Awaiting committer review label Nov 5, 2026
@adamreeve
adamreeve deleted the test-aes-ctr-plaintext-footer branch November 5, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants