Repository navigation
Use Duration for Fate.shutdown and EventQueue.poll - #6642
Open
DomGarguilo wants to merge 1 commit into
Open
DomGarguilo wants to merge 1 commit into
DomGarguilo wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5
Member
Author
|
This is the last batch and will close #4361 once its is merged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4361
Changes
Fate.shutdown(long, TimeUnit)→Fate.shutdown(Duration). The shutdown wait chain (waitForAllFateExecShutdown,waitForDeadResCleanerShutdown,FateExecutor.waitForShutdown) now passes a singleCountDownTimerinstead of(start, timeout, unit).EventQueue.poll(long, TimeUnit)→EventQueue.poll(Duration). Callers use astatic finalconstant.CountDownTimer.startNew(Duration)now caps very large durations (e.g.Duration.ofMillis(Long.MAX_VALUE)) atLong.MAX_VALUEnanos instead of throwingArithmeticException. This matches thelong, TimeUnitoverload andTimer.hasElapsed(Duration), which already do this throughTimer.toNanos. That helper is now package-private and reused here. Documented in the javadoc and covered by a new test.Reasoning
!countdown.isExpired()instead of repeatingSystem.nanoTime() - start < unit.toNanos(timeout). A rawlong startalso no longer has to be ananoTimevalue by convention.static finalconstant, so there are no new allocations. Gains a stronger type and a named constant.Durationandlong, TimeUnitoverloads behave the same, so callers that useLong.MAX_VALUEms to mean "no timeout" (e.g.TabletServerBatchReaderIterator) can switch toDurationwithout gaining a crash path.Co-Authored-By: Claude Opus 5.5