Repository navigation
feat: Remote rendering 4.3b: Display the panels in server mode - #187
Open
LKasianAnsys wants to merge 5 commits into
Open
LKasianAnsys wants to merge 5 commits into
LKasianAnsys wants to merge 5 commits into
Conversation
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
from
October 26, 2026 14:16
00fea7e to
948253f
Compare
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
2 times, most recently
from
October 26, 2026 19:40
c69f813 to
ed4efab
Compare
LKasianAnsys
marked this pull request as ready for review
October 26, 2026 20:15
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
from
October 28, 2026 14:09
ed4efab to
08edec1
Compare
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
from
October 28, 2026 16:16
08edec1 to
00c79fd
Compare
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
from
October 28, 2026 16:30
00c79fd to
0eb7d53
Compare
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
from
October 29, 2026 21:40
0eb7d53 to
720cb31
Compare
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
2 times, most recently
from
November 2, 2026 13:57
652fbeb to
f785a98
Compare
Base automatically changed from
feat/4.3a-forward-mouse-wheel-input-to-server
to
main
November 2, 2026 14:24
LKasianAnsys
force-pushed
the
feat/4.3b-show-panels-in-server-mode
branch
from
November 2, 2026 14:24
f785a98 to
b4311f6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #28
Context
Until now, the server mode visualizer showed the streamed frames but no UI panels. This PR adds the panels on top of the server-mode canvas, and adds a client-side
ServerRendererby sending each panel action to the server as a trigger, so the panel controls work in server mode. See the copilot summary below for a more complete summary of the changes.Key Changes:
ServerRendererwhich implementsIRendererSceneTriggerSendsVisorFrontnendso the panels appear, and sendsset_dark_themeon each build.Manual check:
Start VISOR in server mode with a dataset. Check that the panels now appear. Test hiding a part, toggling the bounding box, and toggling the cross-section widget. Note that these panels do not yet update after an
add_datasetAPI call from the backend: that is addressed in user story 4.4 (#29).Copilot summary
This pull request introduces significant improvements to the server-rendering ("remote rendering") mode in the Visor client, focusing on integrating the panel UI in server mode, refactoring the server-rendering frontend construction, and adding robust tests for server-rendering behavior. The changes simplify the code by removing the need to manually mount the server canvas, update type definitions, and enhance test coverage for both the renderer and the React hook responsible for server mode.
Key changes include:
Server Rendering Integration and Refactoring:
useServerVtkhook has been refactored to build the fullvisorFrontend(including UI panels) instead of just exposing a canvas, and the manual canvas mounting logic inApp.tsxhas been removed. [1] [2] [3] [4]useServerVtkhook now manages the lifecycle and cleanup of the server renderer and frontend, ensuring proper resource management and error handling for schema mismatches.Type and Interface Updates:
CameraSyncSourcenow referencesWasmRendererinstead of the broaderIRenderer, and theaddCameraSettledListenermethod has been removed fromIRendererand related implementations, as it is not relevant for server rendering. [1] [2] [3] [4] [5] [6] [7]Testing Enhancements:
ServerRendererconfirm the correct caching and toggling of camera and widget states, improving confidence in server-rendering correctness.Test and Mock Updates: