Repository navigation
Backport Firestore pipelines to 21.1.x for 21.1.0 - #3820
Open
armando-navarro wants to merge 1 commit into
Open
armando-navarro wants to merge 1 commit into
armando-navarro wants to merge 1 commit into
Conversation
Add @angular/fire/firestore/pipelines and @angular/fire/firestore/lite/pipelines, generated from firebase's pipelines entry points, plus a pipeline() declaration on Lite's Firestore that firebase's own Lite typings leave out. Fixes angular#3693 Refs angular#3755 (cherry picked from commit 80ed66b)
armando-navarro
added
bump: minor
tyler-reitz
approved these changes
Oct 27, 2026
tyler-reitz
left a comment
tyler-reitz
left a comment
Collaborator
There was a problem hiding this comment.
Verified as a clean backport: git range-diff against 80ed66b differs only by the cherry-pick line, and building against this branch's firebase 12.18.0 regenerates both pipelines/firebase.ts files with no diff.
Two things that came in with #3799, for a follow-up on main rather than this PR:
- The
docs/firestore.mdexample declaresconst pipelinetwice in one method, so it doesn't compile as written (TS2451). - The first two specs in
pipelines.spec.tsprovide auseValuemock and then call that mock, so they exercise the spy rather than AngularFire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings #3799 from
mainto the new21.1.xline for the 21.1.0 release.git cherry-pick -xof the squash commit80ed66b, and it applied with no conflicts.Feature for v21 users
@angular/fire/firestore/pipelinesand@angular/fire/firestore/lite/pipelinesentry points for Firestore pipeline operations (Add support for Firestore Enterprise Pipeline Queries #3693), contributed by KingDarBoja.Verification
The two generated
firebase.tsfiles come out the same when built against this branch's firebase 12.18.0, so they need no changes for 21.