Skip to content

refactor(@angular/cli): remove unused code and exports - #34634

Open
MeAkib wants to merge 1 commit into
angular:mainfrom
MeAkib:refactor/cli-unused-code
Open

MeAkib wants to merge 1 commit into
angular:mainfrom
MeAkib:refactor/cli-unused-code

Conversation

@MeAkib

@MeAkib MeAkib commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Remove the findWorkspaceFile utility in utilities/project.ts, which has been unreferenced since the global configuration handling refactor in 746d0c5, and remove the export keyword from eleven symbols that are only referenced within their defining file. None of these are public API: the package declares no exports field and has no public API golden.

Remove the `findWorkspaceFile` utility in `utilities/project.ts`, which has
been unreferenced since the global configuration handling refactor in
746d0c5, and remove the `export` keyword from eleven symbols that are only
referenced within their defining file. None of these are public API: the
package declares no `exports` field and has no public API golden.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase by removing unnecessary exports from various constants, variables, and functions across multiple files, effectively making them internal to their respective modules. Additionally, an unused utility file containing workspace file resolution logic has been deleted. I have no feedback to provide as there are no review comments.

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants