Repository navigation
Correctly load empty {node|side} sets, blocks, maps, etc. - #109
Merged
Merged
Conversation
andrsd
commented
Oct 30, 2026
Owner
- Correct reading of node sets
- Correct reading of side set node list
- Correct reading of coordinates
- Correct reading of node map
- Correct reading of elem map
- Correct reading of blocks
- Correct reading of side sets
- Correct writing of block
- Adding test for reading empty sets
Do not try to read it if there are no nodes
Do not read if there not any
Do not ready if there are not any
Do not read if there are not any
Do not read if there are not any
Do not read any if there are not any
Do not read if there are not any
Do not write if block is empty
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 95.71% 95.80% +0.08%
==========================================
Files 15 15
Lines 771 811 +40
==========================================
+ Hits 738 777 +39
- Misses 33 34 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.