Skip to content

Correctly load empty {node|side} sets, blocks, maps, etc. - #109

Merged
andrsd merged 9 commits into
mainfrom
fix-read-empty-set
Oct 30, 2026
Merged

andrsd merged 9 commits into
mainfrom
fix-read-empty-set

Conversation

@andrsd

@andrsd andrsd commented Oct 30, 2026

Copy link
Copy Markdown
Owner
  • Correct reading of node sets
  • Correct reading of side set node list
  • Correct reading of coordinates
  • Correct reading of node map
  • Correct reading of elem map
  • Correct reading of blocks
  • Correct reading of side sets
  • Correct writing of block
  • Adding test for reading empty sets

Do not try to read it if there are no nodes
Do not read if there not any
Do not ready if there are not any
Do not read if there are not any
Do not read if there are not any
Do not read any if there are not any
Do not read if there are not any
Do not write if block is empty
@andrsd andrsd added the feat New feature or request label Oct 30, 2026
@andrsd andrsd self-assigned this Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.80%. Comparing base (66d9f72) to head (2a9d34d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/file.cpp 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   95.71%   95.80%   +0.08%     
==========================================
  Files          15       15              
  Lines         771      811      +40     
==========================================
+ Hits          738      777      +39     
- Misses         33       34       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@andrsd
andrsd merged commit 26a9c10 into main Oct 30, 2026
8 of 9 checks passed
@andrsd
andrsd deleted the fix-read-empty-set branch October 30, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant