Repository navigation
Run amber-lsp on changed lines as an advisory check - #100
Open
crimson-knight wants to merge 6 commits into
Open
crimson-knight wants to merge 6 commits into
crimson-knight wants to merge 6 commits into
Conversation
--advisory keeps findings non-blocking, so job-level continue-on-error only hid a failed amber-lsp build or a checker exit 2. amber-lsp now builds from amberframework/amber_cli#54 at its reviewed head.
Reverted in the next commit.
This reverts commit f632b09.
…s the job Reverted in the next commit.
…t 2 fails the job" This reverts commit 7a2bff2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI job that runs
amber-lsp checkon the lines this pull request changes. Findings appear as annotations and stay advisory:--advisorymakes the check exit 0 when it finds something. A failed amber-lsp build or a checker exit 2 fails the job, so a broken linter reads red. The job is not a required check.amber-lsp is built from amberframework/amber_cli at ede25163faa5574a0b7d28c83a97eef288d9f272, the reviewed head of amberframework/amber_cli#54, pinned by full commit SHA, because no release includes
checkyet. A later change moves this to a hash-verified release archive.CI proof on this branch: the job passed on the real tree, failed at "Build amber-lsp" on a deliberate build break (run 42913920949), and failed at "Check changed lines" with exit code 2 on a deliberate invalid
exclude_patterns(run 42914184415). Both test commits are reverted, and the final tree equals the fix commit.