Repository navigation
Add 0.17.0 support, report test progress, and cleanup paths - #31
Merged
Merged
Conversation
Save some bytes by only writing the path prefix once or twice.
The macro configuration for file stats in `tests/clar/clar.c` is bugged when targeting mingw-w64, and ends up mismatching the functions and types. See the upstream patch for more info: clar-test/clar@02104ca `build/clar_fix.zig` has been refactored to apply this patch when building tests on a windows machine. This fix should be removed after updating our upstream to a version including the patch.
Test progress is reported through the build system via `std.Progress`. We can only report progress at the suite level since clar's TAP output only reports individual tests after they've been ran. clar also doesn't report how many tests are expected to run, so we can't provide an estimate either. We could get this info by parsing the runner's --list output and applying test filters manually, but that's more effort than it's worth. Failures are printed to stderr on suite completion.
Silently drops the line if parsing or openFile fails, though that's unlikely since clar itself would probably have failed too.
Collaborator
Author
|
To avoid lagging CI runs I haven't added 0.17.0 tests. However I have tested Linux and Windows builds locally and they pass. I will bump the CI version in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Adds Zig 0.17.0 support, which required patching clar on windows builds (see commit). This PR is backwards compatible with 0.16.0.
The test runner has been reintegrated with the build system and properly reports progress and errors. Errors get formatted nicely in the terminal now too.
Source paths have been moved into a zon file to reduce clutter in the build script. I've also removed redundant path prefixes to save some bytes.