Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Bumps
spring.boot.versioninsentinel-dashboard/pom.xmlfrom 2.5.12 to 2.5.15, the last 2.5.x release. This moves the dashboard's Spring Boot stack together (no single library pinned), which updates Spring Framework 5.3.18 -> 5.3.27, Tomcat 9.0.60 -> 9.0.75, Jackson 2.12.6.1 -> 2.12.7.1 and Logback 1.2.11 -> 1.2.12, and addresses the advisories listed in the issue (CVE-2023-20860, CVE-2023-20883, CVE-2022-22970, CVE-2022-22968, CVE-2023-20863, CVE-2023-20861, CVE-2022-42252, CVE-2022-45143, CVE-2023-24998, CVE-2022-42003, CVE-2022-42004). Java 8 support is unchanged.Does this pull request fix one issue?
Fixes #3672
Describe how you did it
One property change.
spring.boot.versionis defined and used only insentinel-dashboard/pom.xml, so no other module is affected (the demos have their own property).Describe how to verify it
What was run on the
1.8branch at a3f40ba, before and after the change:mvn -pl sentinel-dashboard -am install -DskipTests: builds.mvn -pl sentinel-dashboard dependency:list -DincludeScope=runtime: only version changes (Spring Boot, Spring Framework, Tomcat, Jackson, Logback), nothing added or removed.JsonSerializeTestand 2 errors inDashboardConfigTestexist on1.8already). Note: these JUnit 4 tests only run with the JUnit vintage engine on the test classpath, whichsentinel-dashboarddoes not declare, somvn testcurrently runs 0 of them; the engine was added locally for this check only and is not part of this PR./,/version,/app/*,/registry/machine, rule and metric list endpoints, gateway endpoints) sent to each: same HTTP status for every request, and identical response bodies apart from thetimestampfield of error responses.Special notes for reviews
--add-opens java.base/java.io=ALL-UNNAMEDto start, or Spring Boot 2.7/3.x). Kept out of this PR on purpose.