Repository navigation
chore(deps): relax nltk pin to allow patched 3.10.4 - #1275
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1794649872-relax-nltk-pin#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1794649872-relax-nltk-pinPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Contributor
Author
Devin Review🟢 Devin Review found nothing to fix · View findings |
PyTest Results (Fast)6 581 tests ±0 6 544 ✅ - 1 7m 33s ⏱️ +7s Results for commit f3ba3ed. ± Comparison against base commit 608e291. This pull request skips 1 test. |
PyTest Results (Full)6 584 tests ±0 6 547 ✅ - 1 8m 20s ⏱️ - 3m 32s Results for commit f3ba3ed. ± Comparison against base commit 608e291. This pull request skips 1 test. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the exact
nltk = "3.9.4"pin with>=3.10.4,<4so consumers can pick up the release that fixes several high-severity nltk advisories. The exact pin currently makes Dependabot security updates fail in downstream repos that depend onairbyte-cdk(e.g.airbytehq/cloud-mcp-evals, example failure).pyproject.toml:nltk = { version = ">=3.10.4,<4", optional = true }poetry.lock: non-updatingpoetry lock; locksnltk 3.10.4and adds its new required depdefusedxml 0.7.1. No other deps changed.Risk
nltk 3.10 adds a stricter path-security policy (
nltk.pathsec), which is why #968 stayed on 3.9.x. The only CDK nltk usage isUnstructuredParser(airbyte_cdk/sources/file_based/file_types/unstructured_parser.py), which appends/airbyte/nltk_data(fallback/tmp/nltk_data) tonltk.data.pathand downloadspunkt,punkt_tabandaveraged_perceptron_tagger_eng. That path works under 3.10.4 (see test plan). Not checked: production container filesystem permissions or network policy.Pin history (for reviewers)
3.8.1pinef0199933.9.14592368c3.9.47c96f9d3Test plan
poetry run pytest unit_tests/sources/file_based unit_tests/destinations/vector_db_based -q: 851 passed, 2 failed. The 2 failures (test_file_based_stream_reader.py::test_parse_start_date[...], timezone-aware vs naive datetime) also fail onmainwith nltk 3.9.4 and are unrelated.LookupErroron a missing resource, real DOCX parse throughUnstructuredParser(normal, empty, invalid input ->RecordParseError).poetry run ruff check .andpoetry run mypy airbyte_cdkare clean.MCP Evals opened this PR for Caleb
Implemented in session Relax airbyte-cdk nltk pin to patched 3.10.4
Review with Devin · Open in Devin Desktop