Skip to content

chore(deps): relax nltk pin to allow patched 3.10.4 - #1275

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1794649872-relax-nltk-pin
Open

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1794649872-relax-nltk-pin

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Replaces the exact nltk = "3.9.4" pin with >=3.10.4,<4 so consumers can pick up the release that fixes several high-severity nltk advisories. The exact pin currently makes Dependabot security updates fail in downstream repos that depend on airbyte-cdk (e.g. airbytehq/cloud-mcp-evals, example failure).

  • pyproject.toml: nltk = { version = ">=3.10.4,<4", optional = true }
  • poetry.lock: non-updating poetry lock; locks nltk 3.10.4 and adds its new required dep defusedxml 0.7.1. No other deps changed.

Risk

nltk 3.10 adds a stricter path-security policy (nltk.pathsec), which is why #968 stayed on 3.9.x. The only CDK nltk usage is UnstructuredParser (airbyte_cdk/sources/file_based/file_types/unstructured_parser.py), which appends /airbyte/nltk_data (fallback /tmp/nltk_data) to nltk.data.path and downloads punkt, punkt_tab and averaged_perceptron_tagger_eng. That path works under 3.10.4 (see test plan). Not checked: production container filesystem permissions or network policy.

Pin history (for reviewers)

Change Commit Author PR
Added exact 3.8.1 pin ef019993 Serhii Lazebnyi (@lazebnyi) airbytehq/airbyte#43346
Bumped to 3.9.1 4592368c dependabot #43
Bumped to 3.9.4 7c96f9d3 Aaron ("AJ") Steers (@aaronsteers) #968

Test plan

  • poetry run pytest unit_tests/sources/file_based unit_tests/destinations/vector_db_based -q: 851 passed, 2 failed. The 2 failures (test_file_based_stream_reader.py::test_parse_start_date[...], timezone-aware vs naive datetime) also fail on main with nltk 3.9.4 and are unrelated.
  • Unstructured parser tests and scenarios pass on 3.10.4.
  • Smoke script on 3.10.4: parser import and nltk data downloads, sentence/word tokenization and POS tagging, LookupError on a missing resource, real DOCX parse through UnstructuredParser (normal, empty, invalid input -> RecordParseError).
  • poetry run ruff check . and poetry run mypy airbyte_cdk are clean.

MCP Evals opened this PR for Caleb

Implemented in session Relax airbyte-cdk nltk pin to patched 3.10.4

Review with Devin · Open in Devin Desktop


Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot requested a review from a team as a code owner November 14, 2026 09:54
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1794649872-relax-nltk-pin#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1794649872-relax-nltk-pin

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Devin Review

🟢 Devin Review found nothing to fix · View findings

@github-actions

Copy link
Copy Markdown

PyTest Results (Fast)

6 581 tests  ±0   6 544 ✅  - 1   7m 33s ⏱️ +7s
    1 suites ±0      37 💤 +1 
    1 files   ±0       0 ❌ ±0 

Results for commit f3ba3ed. ± Comparison against base commit 608e291.

This pull request skips 1 test.
unit_tests.sources.declarative.test_concurrent_declarative_source ‑ test_read_with_concurrent_and_synchronous_streams

@github-actions

Copy link
Copy Markdown

PyTest Results (Full)

6 584 tests  ±0   6 547 ✅  - 1   8m 20s ⏱️ - 3m 32s
    1 suites ±0      37 💤 +1 
    1 files   ±0       0 ❌ ±0 

Results for commit f3ba3ed. ± Comparison against base commit 608e291.

This pull request skips 1 test.
unit_tests.sources.declarative.test_concurrent_declarative_source ‑ test_read_with_concurrent_and_synchronous_streams

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant