Repository navigation
fix: align v2 cancel dispatch and session setup with ACP - #351
Merged
Merged
Conversation
benbrandt
enabled auto-merge (squash)
November 18, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the v2 runtime and example with the ACP clarifications after the schema v2.0.0-alpha.17 release.
tool_call/cancelandterminal/cancel. An unimplemented method returns-32601. When the method is implemented, its handler distinguishes an unknown or inactive session (-32002withdata.sessionId) from an invalid, final, or non-cancellable item (-32602). Typed handlers and wildcard handlers still run normally. See ACP #2869.session/newstate is sent after the response and that an unsupportedsystemPromptvalue is rejected with-32602without creating or resuming the session. Teach the dual-version example to reject unsupported v2 system prompts and test that both operations leave session state unchanged. See ACP #2870 and ACP #2871.Verification
npm run check: generated-file checks, lint, formatting, spelling, typecheck, build, package checks, 687 tests, and TypeDoc verification.git diff --check