Repository navigation
feat: support MCP-over-ACP in the Codex adapter - #771
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support MCP-over-ACP on ACP v1 and v2. Clients can declare a
type: "acp"server at session setup and serve tools on their existing connection. Codex accepts MCP URLs, not ACP registrations, so the adapter uses the ACP SDK's authenticated loopback HTTP bridge. Its listener and credentials belong to the ACP connection, not an individual session. The adapter redacts the bearer header from its outgoing app-server trace.Compatibility
mcp_2026_07_28. Enable that feature only for threads that actually use a bridged server: the bridge requires modern discovery and does not accept the legacyinitializehandshake.server/discoverbefore Codex falls back toinitialize.CODEX_CONFIGwhen adding registrations. Resolve name conflicts before opening endpoints, including when a server URL uses a dotted config key.Verification
npm run typecheckandnpm run buildnpm test— 2,532 passed, 39 skippednpm run test:integration— 21 passed. Real bundled Codex 0.166.0 discovers and calls a client tool in a session with legacy HTTP and stdio servers, on both ACP versions. The tests also check request-scoped progress, MCP errors, bearer authentication, and listener lifetime.npm run bundle:all— all six platform binaries builtNo live model or API key is required by the new tests. The separate live-model E2E suite was not run.