Skip to content

test: use the running Node executable in supervisor fixtures - #741

Merged
EugeneTheDev merged 2 commits into
agentclientprotocol:mainfrom
tpansino:fix/supervisor-test-node-path
Nov 11, 2026
Merged

EugeneTheDev merged 2 commits into
agentclientprotocol:mainfrom
tpansino:fix/supervisor-test-node-path

Conversation

@tpansino

@tpansino tpansino commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

I maintain the nixpkg of codex-acp, and I'm trying to upgrade from v2.1.1 to v2.5.0. Linux x86-64 builds are currently failing for a few reasons, which I plan to file PRs to fix here upstream.

From Codex:

The supervisor tests generate executable scripts with #!/usr/bin/env node.
These fail to start in the Nix Linux build sandbox, where /usr/bin/env
is absent, causing three output-draining tests to fail.

Use process.execPath in the generated shebangs so fixtures run with the
same Node executable as the test runner.

Related to #742

@tpansino

Copy link
Copy Markdown
Contributor Author

@EugeneTheDev could I please get a review of this? Thanks.

@EugeneTheDev EugeneTheDev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

@EugeneTheDev
EugeneTheDev merged commit 9b2a785 into agentclientprotocol:main Nov 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants