Repository navigation
docs(unstable-v2): say how a receiver handles a request with a null ID - #2875
Merged
Merged
Conversation
The overview forbids `null` request IDs but did not say what a receiver does with a message that has a `method` and `id: null`. Say that the receiver rejects the message with `-32600` and `id: null`, and does not treat it as a notification. This matches the rule for batches on the transports page, and what the TypeScript and Rust SDKs already do on v2 connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v2 overview says request IDs MUST be a string or an integer, never
null. It did not say what a receiver does with a message that has amethodandid: null.Change
The overview now says, in the stable page and its
draft/copy:This matches the rule for batches on the transports page, which also answers a forbidden message shape with
-32600andid: null.Notes
nullIDs on v1. The page now states the behavior they implement.nullrequest IDs in the same words and defines nothing for the receiver. This goes one step further.nullrequest IDs remain valid there.Checks
typospass on the changed files.