Repository navigation
docs(unstable-v2): let a Client send the selected version when it falls back - #2874
Merged
Merged
Conversation
…ls back The initialization page requires every `initialize` request to carry the latest protocol version the Client supports. The same page lets a Client repeat `initialize` with the lower version the Agent selected, and the migration guide tells it to reconnect with a v1 `initialize`. Read literally, both fallbacks broke the rule. - Keep the rule, and say that after the Agent selects a lower version the Client may send that version when it repeats `initialize` or opens a new connection. - Add the same exception to the dual-stack rules in the migration guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v2 initialization page says the
initializerequest MUST include the latest protocol version the Client supports. Two documented fallbacks send a lower version:initializeagain with the version the Agent selected.initialize.Read literally, both broke the rule.
Changes
initializeor opens a new connection. Changed in the stable page and itsdraft/copy.Notes
initialize, because an Agent that implements only v1 may not accept a repeatedinitialize.Checks
typospass on the changed files.