Skip to content

feat(unstable-v2): remove pattern from elicitation string properties - #2864

Merged
benbrandt merged 1 commit into
mainfrom
feat/v2-remove-elicitation-pattern
Nov 18, 2026
Merged

benbrandt merged 1 commit into
mainfrom
feat/v2-remove-elicitation-pattern

Conversation

@benbrandt

Copy link
Copy Markdown
Member

Removes pattern from string properties in v2 elicitation forms. v1 keeps it.

ACP's form schema is based on the MCP elicitation specification. MCP's string schema has minLength, maxLength, format, and default, and no pattern. ACP added pattern on top. A Client then evaluates a regular expression it did not write against what the user types, and the Elicitation RFD had to require bounded evaluation for it. The v2 spec pages never carried that rule. With pattern gone, v2 has the same string keywords as MCP and needs no such rule.

Wire change

This changes the v2 wire format. A v2 form no longer carries pattern.

  • Agents stop sending pattern and check the submitted value themselves. The elicitation page already says Agents SHOULD validate submitted values.
  • Clients stop evaluating pattern.
  • A dual-version Agent drops pattern when it serves v2.

Adapters

Neither adapter needs a change. codex-acp and claude-agent-acp do not send pattern.

Changes

  • agent-client-protocol-schema/src/v2/elicitation.rs: StringPropertySchema loses the pattern field and its builder method. A test shows that the type reads a form that still has pattern and does not keep the keyword.
  • schema/v2/schema.json, schema/v2/schema.unstable.json, and both schema.mdx pages: regenerated.
  • elicitation.mdx, stable and draft: the text property row and the sentence about ECMA-262 syntax.
  • migration.mdx: a new Elicitation section, the elicitation/create row in the method table, and one item at the end of the Agent and Client checklists.
  • Tracking RFD: the removal is in the change list.
  • Elicitation RFD: one sentence notes that ACP v2 removes pattern. The RFD describes v1, so the rest stays.

Checks

The generator tests in all four feature sets, cargo test --all-features, the three clippy runs, rustdoc, Prettier, cargo fmt, and typos pass. Regenerating the schema again produces no further diff.

ACP added `pattern` on top of MCP's string schema, which the elicitation
form schema is based on. A Client then evaluates a regular expression it did
not write, and the Elicitation RFD had to require bounded evaluation for it.
MCP's string schema has no `pattern`.

- Remove `pattern` from `StringPropertySchema` in the v2 types and schema.
  The v2 type ignores a `pattern` it receives.
- Drop the keyword from the elicitation page, stable and draft.
- Add an Elicitation section and checklist items to the migration guide.
- Record the removal in the tracking RFD and note it in the Elicitation
  RFD.

v1 keeps `pattern`.
@benbrandt
benbrandt requested a review from a team as a code owner November 18, 2026 09:12
@benbrandt
benbrandt merged commit 4307210 into main Nov 18, 2026
13 checks passed
@benbrandt
benbrandt deleted the feat/v2-remove-elicitation-pattern branch November 18, 2026 09:51
@acp-release-bot acp-release-bot Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant