Repository navigation
docs: network-egress.md describes the actor certificate checks the egress gateway makes - #3716
Open
Eric Curtin (ericcurtin) wants to merge 2 commits into
Open
Eric Curtin (ericcurtin) wants to merge 2 commits into
Eric Curtin (ericcurtin) wants to merge 2 commits into
Conversation
The guide required an ActorIdentity extension, the atunnel purpose and a UID match. The egress gateway checks none of them. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
Julian Gutierrez Oschmann (@juli4n) Max Thompson (@thompsonmax) PTAL when you have a moment, thank you! The failing envoy e2e job is TestRequestParking, unrelated to this docs change. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide said the PEP must read the
ActorIdentityextension, require theatunnelpurpose and match the actor UID.verifyActorCertificateandvalidateActordo none of these. The guide now states what is checked and the name reuse limitation.Fixes #3709
AI use: AI-assisted. I checked the text against
egress.go.