Repository navigation
ate-env-api: report a missing environment as NotFound on guest calls - #125
Open
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
Open
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
Conversation
Signed-off-by: KR Ravindra <42912207+KR-Ravindra@users.noreply.github.com>
KR Ravindra (KR-Ravindra)
force-pushed
the
fix/guest-call-missing-env-notfound
branch
from
November 12, 2026 08:16
1740eb9 to
b98fa3d
Compare
KR Ravindra (KR-Ravindra)
marked this pull request as ready for review
November 12, 2026 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
read,write,shelland MCP tool calls on a deleted or never-created environment fail withUnimplementedinstead ofNotFound. The router answers a plain HTTP 404 for an actor it has no route to, grpc-go maps that toUnimplemented, andensureAwaketakes any code other thanUnavailableas an answer from a live guest, so the control-plane read that would say NotFound never happens.Fixes #121
Fix
Treat
Unimplementedfrom the wake probe likeUnavailable: read the actor state, which surfaces a missing environment as NotFound throughtoGRPCError. An actor the control plane knows but the router cannot route yet stays on the existing wake/running budgets.How tested
New
TestGuestCallOnMissingEnvironmentIsNotFoundfails on main and passes with the change;go test ./...,go vet, gofmt clean.Experimented and verified with an AI agent.