Repository navigation
feat: Add malware scanning and scan-before-pack support - #944
Open
yeshwanthkai wants to merge 5 commits into
Open
yeshwanthkai wants to merge 5 commits into
yeshwanthkai wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| const url = new URL(reportUrl, `${deployServiceUrl}/`).href | ||
| aioLogger.debug(`Downloading scan report from ${url}`) | ||
| let report = await this.request(url, options, [200, 503]) | ||
| while (report.status === 503) { |
Contributor
There was a problem hiding this comment.
Do we also send 429 from DeployService if there are too many requests? What are current limits?
Member
Author
There was a problem hiding this comment.
Currently, rate limiting is not set on deploy service side, but if DD returns 429, we will forward the same to the CLI. They had not mentioned 429 for the downloadReport API though. I will include 429 also in this status list
…I response headers
sandeep-paliwal
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aio app scanwhich just performs malware scanning on the app.aio app packto use scan before packing the app.--no-scanflag toaio app packfor the user to skip scanning and proceed with packing the app.pack-helperRelated Issue
Motivation and Context
It is to enable malware scanning for ISV apps and to make the scan results available for the user in CLI itself.
How Has This Been Tested?
I linked the local app plugin repo to my aio and tested the
aio app scanandaio app packon both stage and production environments.Unit tests have also been added for the new changes.
Screenshots (if appropriate):
Types of changes
Checklist: