Repository navigation
Conversation
Read SSE response bytes and decode complete lines as UTF-8. Preserve CR, LF and CRLF framing across chunks, regardless of HTTP charset hints or client defaults.
🧪 Code Coverage (vs
|
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST and JSON-RPC streaming clients share an SSE reader that delegates decoding to HTTPX or HTTPX2. When the response declares an ISO-8859-1 charset or the caller sets an ISO-8859-1 client default, a valid UTF-8 SSE payload such as
café 東京comes back corrupted. The SSE standard requires UTF-8 decoding.Read response bytes, keep the existing CR, LF, and CRLF framing, and decode each complete line as UTF-8. The regression feeds one byte at a time so both multibyte characters and CRLF cross chunk boundaries. #1259 covers leading byte-order mark handling.
Validation
0fc0d3a, both charset override cases corrupted the payload and the UTF-8 control passed. The fix passes all three cases with HTTPX and HTTPX2.scripts/lint.shanduv buildpassed.OpenAI Codex helped investigate, implement, and test this change.