Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/a2a/compat/v0_3/rest_transport.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ async def delete_task_push_notification_config(
"""Deletes the push notification configuration for a specific task."""
await self._execute_request(
'DELETE',
f'/v1/tasks/{request.task_id}/pushNotificationConfigs/{request.id}',
f'/v1/tasks/{_quote_id(request.task_id)}'
f'/pushNotificationConfigs/{_quote_id(request.id)}',
context=context,
)

Expand Down
24 changes: 24 additions & 0 deletions tests/compat/v0_3/test_rest_transport.py
Original file line number Diff line number Diff line change
Expand Up @@ -990,3 +990,27 @@ async def test_get_task_does_not_return_task_named_by_id_prefix(
# MethodNotFoundError.
with pytest.raises(MethodNotFoundError):
await transport.get_task(GetTaskRequest(id='t1?x'))

@pytest.mark.asyncio
async def test_delete_push_config_does_not_delete_config_named_by_prefix(
self, transport: CompatRestTransport
):
for config_id in ('alerts', 'alerts#ops'):
await transport.create_task_push_notification_config(
TaskPushNotificationConfig(
task_id='t1',
id=config_id,
url='https://hooks.example.com/hook',
)
)

await transport.delete_task_push_notification_config(
DeleteTaskPushNotificationConfigRequest(
task_id='t1', id='alerts#ops'
)
)

response = await transport.list_task_push_notification_configs(
ListTaskPushNotificationConfigsRequest(task_id='t1')
)
assert [config.id for config in response.configs] == ['alerts']
Loading