Skip to content

[BUG] Flaky WelcomeViewProvider test #2326

Description

@rrewll

Describe the bug
The WelcomeViewProvider.visual.tsx test is flaky:

To Reproduce
Write the steps that show the bug:

  1. Commit something to webview-ui
  2. Create PR
  3. Wait PR checks
  4. If Visual Regression / webview-visual (pull_request) check failed, go to the logs
  5. Find the next logs or similar:
    Error: high-contrast-light welcome action boundary: 2.34:1 (required 3:1; foreground rgba(34, 88, 142, 0.494); background rgba(255, 255, 255, 1.00))

    expect(received).toBeGreaterThanOrEqual(expected)

    Expected: >= 3
    Received:    2.337314441758872

       at ../playwright/contrast.ts:198

      196 | 			: options.minimum
      197 | 	const diagnostic = `${options.label}: ${ratio.toFixed(2)}:1 (required ${minimum}:1; foreground ${styles.foreground}; background rgba(${effectiveBackground.r.toFixed(0)}, ${effectiveBackground.g.toFixed(0)}, ${effectiveBackground.b.toFixed(0)}, ${effectiveBackground.a.toFixed(2)}))`
    > 198 | 	expect(ratio, diagnostic).toBeGreaterThanOrEqual(minimum)
          | 	                          ^
      199 | 	return { ratio, minimum, foreground: effectiveForeground, background: effectiveBackground }
      200 | }
      201 |
        at expectContrast (/__w/Zoo-Code/Zoo-Code/webview-ui/playwright/contrast.ts:198:28)
        at /__w/Zoo-Code/Zoo-Code/webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.visual.tsx:25:4
  ✘  96 [chromium] › src/components/welcome/__tests__/WelcomeViewProvider.visual.tsx:8:2 › renders the full welcome screen in the VS Code high-contrast-light theme (1.4s)
  ✓  95 [chromium] › src/components/welcome/__tests__/WelcomeViewProvider.visual.tsx:8:2 › renders the full welcome screen in the VS Code high-contrast theme (1.6s)
Notice:   1 failed
    [chromium] › src/components/welcome/__tests__/WelcomeViewProvider.visual.tsx:8:2 › renders the full welcome screen in the VS Code high-contrast-light theme 

What version of zoo are you running
3.94.0

Activity

  1. added theissue type on Nov 5, 2026
  2. added a commit that references this issue on Nov 5, 2026
    5ca1eb8
  3. rrewll commented on Nov 5, 2026

    @rrewll
    ContributorAuthor

    claiming

  4. added a commit that references this issue on Nov 6, 2026
    e8790cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions