Repository navigation
Package cleanup - #677
Open
ZacMarcus wants to merge 4 commits into
Open
Package cleanup#677ZacMarcus wants to merge 4 commits into
ZacMarcus wants to merge 4 commits into
Conversation
Bump System.IdentityModel.Tokens.Jwt 8.1.0 -> 8.23.0 in OAuth2Client, which lifts the resolved System.Text.Json from 8.0.4 to 8.0.5 (GHSA-8g4q-xg66-9fp4). Bump Microsoft.Extensions.Configuration.Json 8.0.0 -> 8.0.1 in the test project, which drops its System.Text.Json 8.0.0 package dependency on net8.0 (GHSA-hh2w-p6rv-4g7w, GHSA-8g4q-xg66-9fp4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Set NuGetAuditMode to all so restore checks the full dependency graph, not just direct references. Combined with the existing WarningsAsErrors for NU1901-NU1905, a vulnerable transitive package now fails restore instead of going unnoticed, as System.Text.Json did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test project: - Remove Microsoft.Extensions.Configuration. It used a floating "*" version that resolved to 10.x while the other Microsoft.Extensions packages are on 8.x, and it is already brought in by Configuration.Json (now 8.0.0). - Remove Microsoft.Extensions.Configuration.FileExtensions, also brought in by Configuration.Json (still resolves 8.0.1). - Bump Microsoft.NET.Test.Sdk 17.11.1 -> 17.14.1 and xunit 2.9.2 -> 2.9.3. OAuth2Client: - Bump Newtonsoft.Json 13.0.3 -> 13.0.4 and System.Net.Http.Json 8.0.0 -> 8.0.1. All bumps stay within the current major version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Neither package is referenced anywhere in the code. CompareNETObjects was however the only thing bringing in Microsoft.CSharp, which ClientUtils needs for its use of dynamic, so reference Microsoft.CSharp 4.7.0 directly instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A tidy-up of package references across the three projects. All version bumps stay within the current major version.
Removed
CompareNETObjects4.83.0JsonSubTypes2.0.1Microsoft.Extensions.Configuration(Version="*")Microsoft.Extensions.*packages are on 8.x. It's already brought in byConfiguration.Json, so it now resolves 8.0.0.Microsoft.Extensions.Configuration.FileExtensions8.0.1Configuration.Json(still resolves 8.0.1)Added
Microsoft.CSharp4.7.0ClientUtils.ConvertTypeusesdynamic, which needsMicrosoft.CSharpon .NET Standard 2.0. It was previously only brought in byCompareNETObjects; without it the build fails with CS0656.Updated
Newtonsoft.JsonSystem.Net.Http.JsonMicrosoft.NET.Test.SdkxunitThings to be aware of
Xero.NetStandard.OAuth2.csprojappears to be generated. It's only changed by the "Releasing x.y.z" commits, so the next release will might bringCompareNETObjectsandJsonSubTypesback and dropMicrosoft.CSharp. For the removal to stick, the generator's.csprojtemplate needs the same change.Xero.NetStandard.OAuth2currently getCompareNETObjectsandJsonSubTypeswithout asking for them. Any app using either without its own reference would need to add one when upgrading. This is unlikely, but it's a visible change.Not included
These are larger changes which I will do in separate PRs:
IdentityModel7.0.0 is deprecated in favour ofDuende.IdentityModel. Switching changes namespaces in OAuth2Client.xunitv2 is deprecated in favour ofxunit.v3, which would also mean movingxunit.runner.visualstudioto a newer major version.Microsoft.Extensions.*8.x → 10.x andMicrosoft.NET.Test.Sdk17 → 18 in the test project.Testing
dotnet restorepasses withNuGetAuditMode=all(from Fix vulnerable transitive System.Text.Json dependency #675), and there are no vulnerable packages.dotnet buildsucceeds for the full solution. The only warnings are the existing CS0472 ones in the generated code.dotnet test --list-testsdiscovers the same 2057 tests as before. I haven't run the suite locally since it needs the Prism mock server; CI will cover it.