Repository navigation
806/807: remove code/tests for settings instance_id and omit_instanceID - #878
Merged
Merged
Conversation
- appears to be deprecated or undefined behaviour, possibly added as backwards compatibility for clients without a uuid() function, but generally ODK tools expect instanceID to be a "uuid: <uuid>" string. - the setting value would be passed into `@jr:preload` for the binding on the primary instance meta instanceID element. In the javarosa library the QuestionPreloader seems to handle uid, date, property, and timestamp (per the ODK XForms spec), and otherwise raises an error: "Do not know how to handle preloader". https://github.com/getodk/javarosa/blob/v6.0.0/src/main/java/org /javarosa/core/model/utils/QuestionPreloader.java#L40 - see pyxform/XLSForm#807 for further research notes.
- appears to be deprecated or undefined behaviour, possibly added as backwards compatibility for clients without a uuid() function, but generally ODK tools expect instanceID to be a "uuid: <uuid>" string. - see pyxform/XLSForm#806 for further research notes.
- apply other constants to definition block in xls2json.py
- replace narrative comments with descriptions from ODK spec, since that seems the most useful info about what/why those elements are added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #806
Closes #807
Why is this the best possible solution? Were any other approaches considered?
Grouped these into one PR since the code is very close or overlaps. As discussed in the tickets, these settings allowed modifying
instanceIDbehaviour in ways that are not supported or are at least not typical.What are the regression risks?
Forms or clients that relied on these settings/behaviour would not work.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No, these settings were not documented on xlsform.org or ODK docs.
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code