Skip to content

added test for send_frame_options_header - #5638

Closed
pbearne wants to merge 16 commits into
WordPress:trunkfrom
pbearne:59851-send_frame_options_header
Closed

added test for send_frame_options_header#5638
pbearne wants to merge 16 commits into
WordPress:trunkfrom
pbearne:59851-send_frame_options_header

Conversation

@pbearne

@pbearne pbearne commented Nov 8, 2023

Copy link
Copy Markdown

@pbearne @swissspidy
Update tests/phpunit/tests/functions/sendFrameOptionsHeader.php
cf53c37 
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@github-actions

github-actions Bot commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, swissspidy, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@pbearne @swissspidy
Update tests/phpunit/tests/functions/sendFrameOptionsHeader.php
1fa241e 
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@github-actions

github-actions Bot commented Mar 1, 2024

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pbearne added 10 commits March 1, 2024 17:51
@pbearne
Adjust unit test for send_frame_options_header function
3151dcb 
The unit test for send_frame_options_header function is updated to manage PHP Warnings and check response headers. setUp and tearDown methods are added to manage error levels, and the test_send_frame_options_header method now checks the 'X-Frame-Options' in the response headers. Also, this update necessitated the inclusion of xdebug as part of the test suite.
@pbearne
Adjust unit test for send_frame_options_header function
d85cdf3 
The unit test for send_frame_options_header function is updated to manage PHP Warnings and check response headers. setUp and tearDown methods are added to manage error levels, and the test_send_frame_options_header method now checks the 'X-Frame-Options' in the response headers. Also, this update necessitated the inclusion of xdebug as part of the test suite.
@pbearne
Remove unnecessary whitespace from PHPUnit test
8b9271c 
Two superfluous line breaks were removed from the PHPUnit test for sendFrameOptionsHeader function to improve code readability. This refactoring does not alter the functionality or performance of the test suite.
@pbearne
Update assertStringContainsString statement in PHPUnit test
ef34cdf 
This patch adjusts the formatting of the assertStringContainsString statement in the PHPUnit test for the sendFrameOptionsHeader function. It simply removes an extra space without making substantial changes to the code or its functionality.
@pbearne
Update assertStringContainsString statement in PHPUnit test
c0bf706 
This patch adjusts the formatting of the assertStringContainsString statement in the PHPUnit test for the sendFrameOptionsHeader function. It simply removes an extra space without making substantial changes to the code or its functionality.
@pbearne
debug
9290537
@pbearne
debug
ee06c9e
@pbearne
Remove debug statement from test file
ad12b1e 
The debug statement (`var_dump( $headers );`) was removed from the sendFrameOptionsHeader PHPUnit test. This modification makes the test output cleaner and more focused on asserting the expected conditions.
@pbearne
Remove unneeded error reporting in sendFrameOptionsHeader test
528c182 
The line setting the error level was removed from the sendFrameOptionsHeader PHPUnit test. This tweak simplifies the test setup and helps to reduce the side effects associated with modifying the global error reporting level.
@pbearne
Simplify sendFrameOptionsHeader test by removing error suppression
b9c5368 
The set_up method in sendFrameOptionsHeader test was modified to get rid of the error suppression line. This change helps decrease the overall complexity of the test setup. Moreover, it minimizes potential negative impacts related to altering the global error reporting level.
pbearne and others added 2 commits March 4, 2024 09:10
@pbearne @swissspidy
Update tests/phpunit/tests/functions/sendFrameOptionsHeader.php
217caa5 
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@pbearne
Update sendFrameOptionsHeader.php
9ac2ddc 
remove not needed test
@lancewillett
lancewillett requested a balanced review from Copilot October 31, 2026 17:03
Copilot AI reviewed Oct 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the added PHPUnit coverage of send_frame_options_header().

No open issues 🎉

What changed in this PR

Adds PHPUnit coverage for WordPress’s send_frame_options_header() function, associated with Trac ticket #59851.

Changes:

  • Verifies that the function sends X-Frame-Options: SAMEORIGIN.
  • Runs the test in a separate process and requires Xdebug’s header inspection function.
File Description
tests/​phpunit/​tests/​functions/​sendFrameOptionsHeader.php Adds an isolated test for the expected frame-options header.

Review effort: Balanced

lancewillett
lancewillett approved these changes Oct 31, 2026
View reviewed changes

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the outgoing X-Frame-Options: SAMEORIGIN header with Xdebug enabled in the isolated PHPUnit child process. The new test executes one assertion with zero skips in both single-site and multisite; the related existing header test also passes. Coding standards pass.

The earlier requests for a real header assertion and process isolation are addressed. Approved on code and local validation. Please refresh against trunk so we have current CI before landing.

AI review · gpt-6

wporg-sync pushed a commit that referenced this pull request Oct 31, 2026
@lancewillett
Tests: Verify the frame options response header.
bc2512f 
Assert that `send_frame_options_header()` sends `X-Frame-Options: SAMEORIGIN`, using Xdebug header inspection in an isolated process.

Developed in: #5638

Props pbearne, swissspidy.
See #59851.


git-svn-id: https://develop.svn.wordpress.org/trunk@65153 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 31, 2026
@lancewillett
Tests: Verify the frame options response header.
0cd3725 
Assert that `send_frame_options_header()` sends `X-Frame-Options: SAMEORIGIN`, using Xdebug header inspection in an isolated process.

Developed in: WordPress/wordpress-develop#5638

Props pbearne, swissspidy.
See #59851.

Built from https://develop.svn.wordpress.org/trunk@65153


git-svn-id: http://core.svn.wordpress.org/trunk@64302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

lancewillett commented Oct 31, 2026

Copy link
Copy Markdown
Member

PR #5638 landed in https://core.trac.wordpress.org/changeset/65153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@lancewillett lancewillett lancewillett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbearne @lancewillett @swissspidy