test for _wp_check_existing_file_names by pbearne · Pull Request #2332 · WordPress/wordpress-develop

pbearne · 2022-02-17T23:48:04Z

test for _wp_check_existing_file_names

Trac ticket:https://core.trac.wordpress.org/ticket/55192

costdev

Thanks for writing these tests Paul!

I have made some suggestions to improve consistency, readability and coverage in the tests.

costdev · 2022-02-18T05:51:53Z

+				'filename' => 'filename.png',
+				'files'    => array( 'filename-rotated.png' ),
+				'expected' => true,
+			),


There should be two additional datasets:

'a file with no extension' that tests a 'filename' such as filename - expected should be true.

This covers filenames that don't match this branch.

'a file with no filename' that tests a 'filename' such as .htaccess - expected should be false.

This covers this branch.

both of these return false
because of this code
// Edge case, file names like .ext.
if ( empty( $fname ) || empty( $ext ) ) {

return false; } Do you feel the code should changed to return true?

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

…mes' into #53971_wp_check_existing_file_names # Conflicts: # tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

costdev

Looks great Paul! Just two suggestions to use a single underscore _ instead of two underscores __ in the method names.

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Copilot

🟢 Approval recommended

There are no active review issues for the change adding filename-conflict test coverage.

No open issues 🎉

What changed in this PR

Adds PHPUnit coverage for _wp_check_existing_file_names(), WordPress’s helper for detecting filename conflicts with generated image variants, in support of Trac ticket #55192.

Changes:

Adds data-driven tests for dimension, scaled, and rotated suffixes, plus filenames without a name or extension.
Adds a blank line in the helper; production behavior is unchanged.

File	Description
`tests/phpunit/tests/functions/_wpCheckExistingFileNames.php`	Adds ten test cases for filename matching and edge cases.
`src/wp-includes/functions.php`	Whitespace-only change in the empty-filename guard.

_{Review effort: Balanced}

lancewillett

The requested naming changes are present. All ten cases passed locally in randomized single-site and multisite runs; Copilot also found no active issue.

On the older extensionless-filename question: no production change is needed. filename against filename correctly returns false; filename against filename-1x1 returns true with the current implementation. That latter row would clarify the earlier discussion, but I do not consider it necessary before landing this coverage.

_{AI review · gpt-6}

lancewillett · 2026-10-31T19:59:12Z

One landing prerequisite remains: GitHub currently reports no checks for this head. Could you refresh the branch so current CI runs? The local test review is approved.

_{AI review · gpt-6}

github-actions · 2026-10-31T20:49:56Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @mauriac.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, costdev, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

@propsbot add <username> to give props to a GitHub user. Requires write access.
@propsbot remove <username> to leave a user out of the props. Requires write access.
@propsbot refresh to refresh this list. Adding the props-bot label works too.

github-actions · 2026-10-31T20:53:22Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Test `_wp_check_existing_file_names()` against image dimensions, scaled and rotated suffixes, and filenames without a basename or extension. Developed in: #2332 Props pbearne, azouamauriac, costdev. Fixes #55192. git-svn-id: https://develop.svn.wordpress.org/trunk@65154 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-10-31T21:17:16Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 65154
GitHub commit: d16d2fa

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

Test `_wp_check_existing_file_names()` against image dimensions, scaled and rotated suffixes, and filenames without a basename or extension. Developed in: WordPress/wordpress-develop#2332 Props pbearne, azouamauriac, costdev. Fixes #55192. Built from https://develop.svn.wordpress.org/trunk@65154 git-svn-id: http://core.svn.wordpress.org/trunk@64303 1a063a9b-81f0-0310-95a4-ce76da25c4cd

mauriac · 2026-10-31T22:11:54Z

The following contributors have not linked their GitHub and WordPress.org accounts: @mauriac.

done

test for _wp_check_existing_file_names

c17fb45

mauriac reviewed Feb 18, 2022

View reviewed changes

Comment thread tests/phpunit/tests/functions/_wpCheckExistingFileNames.php Resolved

mauriac reviewed Feb 18, 2022

View reviewed changes

Comment thread tests/phpunit/tests/functions/_wpCheckExistingFileNames.php Resolved

costdev requested changes Feb 18, 2022

View reviewed changes

pbearne and others added 8 commits February 18, 2022 10:10

test for _wp_check_existing_file_names

27816e4

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

ebeee82

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

2359668

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

79ad764

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

55b1d4d

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

131bef0

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

tests for _wp_check_existing_file_names

c1b29e3

Merge remote-tracking branch 'origin/#53971_wp_check_existing_file_na…

359e396

…mes' into #53971_wp_check_existing_file_names # Conflicts: # tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

costdev requested changes Apr 30, 2022

View reviewed changes

Comment thread tests/phpunit/tests/functions/_wpCheckExistingFileNames.php Resolved

Comment thread tests/phpunit/tests/functions/_wpCheckExistingFileNames.php Resolved

pbearne and others added 2 commits April 30, 2022 10:29

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

7c22f98

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

752023b

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

costdev reviewed May 2, 2022

View reviewed changes

Comment thread tests/phpunit/tests/functions/_wpCheckExistingFileNames.php Resolved

pbearne and others added 4 commits May 2, 2022 18:13

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

0c9c5f9

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>

added tests for no filename and no ext

6b28766

Merge branch 'WordPress:trunk' into #53971_wp_check_existing_file_names

d4c0434

removed the extra test || empty( $ext )

d8452dc

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:11

lancewillett requested a balanced review from Copilot October 31, 2026 19:53

Copilot started reviewing on behalf of lancewillett October 31, 2026 19:54

View session

Copilot AI reviewed Oct 31, 2026

View reviewed changes

lancewillett approved these changes Oct 31, 2026

View reviewed changes

Merge branch 'trunk' into #53971_wp_check_existing_file_names

c2f6a87

github-actions Bot closed this Oct 31, 2026

Conversation

pbearne commented Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

costdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

costdev Feb 18, 2022

Choose a reason for hiding this comment

Uh oh!

pbearne May 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

costdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

lancewillett left a comment

Choose a reason for hiding this comment

Uh oh!

lancewillett commented Oct 31, 2026

Uh oh!

github-actions Bot commented Oct 31, 2026

Unlinked Accounts

Uh oh!

github-actions Bot commented Oct 31, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

github-actions Bot commented Oct 31, 2026

Uh oh!

mauriac commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pbearne commented Feb 17, 2022 •

edited

Loading