Repository navigation
Build/Test Tools: Forward env:start arguments to Composer - #15304
lancewillett wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change restoring command-line argument forwarding to Composer.
No open issues 🎉
What changed in this PR
Restores forwarding of npm run env:start -- ... arguments to Composer, fixing an omission introduced when Composer execution moved into start.js in #9360.
Changes:
- Appends command-line arguments to
composer update -Wwhile retaining the existing retry and error-handling flow.
| File | Description |
|---|---|
tools/local-env/scripts/start.js |
Forwards additional command-line arguments to Composer. |
Review effort: Balanced
|
PR #15304 landed in https://core.trac.wordpress.org/changeset/65205 |
github-project-automation
Bot
moved this from In review
to Done
in WordPress Project Build Tooling
…ment startup. Forward arguments supplied to `npm run env:start -- ...` to `composer update -W`. This restores options such as `--dry-run`, which stopped reaching Composer when its invocation moved into `start.js`. Follow-up to [65150]. Developed in: #15304 Props adrianmoldovanwp, lucatume. Fixes #62807. git-svn-id: https://develop.svn.wordpress.org/trunk@65205 602fd350-edb4-49c9-b593-d223f7449a82
…ment startup. Forward arguments supplied to `npm run env:start -- ...` to `composer update -W`. This restores options such as `--dry-run`, which stopped reaching Composer when its invocation moved into `start.js`. Follow-up to [65150]. Developed in: WordPress/wordpress-develop#15304 Props adrianmoldovanwp, lucatume. Fixes #62807. Built from https://develop.svn.wordpress.org/trunk@65205 git-svn-id: http://core.svn.wordpress.org/trunk@64354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Restore forwarding of arguments passed to
npm run env:start -- ...to Composer. The change in r65150 moved Composer intostart.jsbut omitted those arguments. For example,npm run env:start -- --dry-runmust pass--dry-runtocomposer update -W.Follow-up to #9360. Trac ticket: https://core.trac.wordpress.org/ticket/62807
Verification used the real npm script with a recording Docker stub: no arguments, one argument, and multiple arguments reach Composer as expected. Retry success, persistent failure, and failed container startup retain their exit behavior. Syntax, JSHint, and diff checks passed. The probe did not run real Composer or Docker.
AI assistance: Codex (gpt-6) prepared the one-line fix and controlled verification.