Repository navigation
Tests: Unregister custom post type in getDefaultCommentStatus tests teardown - #15295
Open
rejaulalomkhan wants to merge 1 commit into
Open
rejaulalomkhan wants to merge 1 commit into
rejaulalomkhan wants to merge 1 commit into
Conversation
…eardown See #65893.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the custom post type cleanup intended to improve test isolation.
No open issues 🎉
What changed in this PR
This PR improves test isolation in Tests_Comment_GetDefaultCommentStatus by cleaning up the custom post type registered during testing.
Changes:
- Adds
tear_down()to unregisterwith_comments_cpt, preventing it from leaking into subsequent tests. - Preserves the parent class’s teardown behavior.
| File | Description |
|---|---|
tests/phpunit/tests/comment/getDefaultCommentStatus.php |
Adds custom post type cleanup before calling the parent teardown. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Tests_Comment_GetDefaultCommentStatus(tests/phpunit/tests/comment/getDefaultCommentStatus.php),test_supported_custom_post_type_uses_opposed_comment_and_ping_options()registers a custom post type (with_comments_cpt) without unregistering it intear_down().This leaks the registered post type into the global registry, causing test pollution for subsequent test classes in the same run.
This PR adds a
tear_down()method toTests_Comment_GetDefaultCommentStatusto unregisterwith_comments_cpt.Testing Instructions
vendor/bin/phpunit tests/phpunit/tests/comment/getDefaultCommentStatus.php-> PASS (4 tests, 8 assertions).vendor/bin/phpunit -c tests/phpunit/multisite.xml tests/phpunit/tests/comment/getDefaultCommentStatus.php-> PASS (4 tests, 8 assertions).vendor/bin/phpcs tests/phpunit/tests/comment/getDefaultCommentStatus.php-> PASS (0 errors, 0 warnings).Trac ticket: https://core.trac.wordpress.org/ticket/65893
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
Use of AI Tools
getDefaultCommentStatus.phpteardown, addedtear_down()method, verified tests locally, and prepared the patch. I reviewed every line, ran the tests listed above, and take responsibility for the change.