Skip to content

Tests: Unregister custom post type in getDefaultCommentStatus tests teardown - #15295

Open
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-comment-getdefaultcommentstatus
Open

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-comment-getdefaultcommentstatus

Conversation

@rejaulalomkhan

Copy link
Copy Markdown

Description

In Tests_Comment_GetDefaultCommentStatus (tests/phpunit/tests/comment/getDefaultCommentStatus.php), test_supported_custom_post_type_uses_opposed_comment_and_ping_options() registers a custom post type (with_comments_cpt) without unregistering it in tear_down().

This leaks the registered post type into the global registry, causing test pollution for subsequent test classes in the same run.

This PR adds a tear_down() method to Tests_Comment_GetDefaultCommentStatus to unregister with_comments_cpt.

Testing Instructions

  1. Run vendor/bin/phpunit tests/phpunit/tests/comment/getDefaultCommentStatus.php -> PASS (4 tests, 8 assertions).
  2. Run vendor/bin/phpunit -c tests/phpunit/multisite.xml tests/phpunit/tests/comment/getDefaultCommentStatus.php -> PASS (4 tests, 8 assertions).
  3. Run vendor/bin/phpcs tests/phpunit/tests/comment/getDefaultCommentStatus.php -> PASS (0 errors, 0 warnings).

Trac ticket: https://core.trac.wordpress.org/ticket/65893


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use of AI Tools

  • Tool: Antigravity
  • Model: Gemini 3.8 Flash
  • Used for: Identified the missing custom post type unregistration in getDefaultCommentStatus.php teardown, added tear_down() method, verified tests locally, and prepared the patch. I reviewed every line, ran the tests listed above, and take responsibility for the change.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the custom post type cleanup intended to improve test isolation.

No open issues 🎉

What changed in this PR

This PR improves test isolation in Tests_Comment_GetDefaultCommentStatus by cleaning up the custom post type registered during testing.

Changes:

  • Adds tear_down() to unregister with_comments_cpt, preventing it from leaking into subsequent tests.
  • Preserves the parent class’s teardown behavior.
File Description
tests/​phpunit/​tests/​comment/​getDefaultCommentStatus.php Adds custom post type cleanup before calling the parent teardown.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants